fix bug in output filename calculation in plot_radial_build.py

[alekitto]

Description

Filename calculation in plot_radial_build.py is done taking the last 10 characters of the input file path.
This behaviour is not safe and can lead to NotFoundError to be thrown or cause path traversal in the worst case.

The fix replaces the unsafe part picking up the basename of the file (without extension) and prepending it to _radial_build.{save_format} static part.

This also fixes test_plot_radial_build run is some environments.

Checklist

I confirm that I have completed the following checks:

• I have justified any large differences in the regression tests caused by this pull request in the comments.
• I have added new tests where appropriate for the changes I have made.
• If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
• If I have made documentation changes, I have checked they render correctly.
• I have added documentation for my change, if appropriate.

[timothy-nunn]

Hi @alekitto,

Thank you for your contribution to the PROCESS repository by identifying and proposing a fix to this bug.

I think pathlib may offer a nicer, more modern fix to this bug, and have suggested as such.

[timothy-nunn]

Suggested change

	f"{args.outputdir}/{os.path.splitext(os.path.basename(args.input))[0]}_radial_build.{save_format}",
	f"{args.outputdir}/{Path(args.input).stem}_radial_build.{save_format}",

This is probably the correct and less-verbose way to do this in newer versions of Python (of course this would also make the import os redundant.

[alekitto]

Yes, you're right. Fixed

[timothy-nunn]

Thank you very much :)