WIP:3007 remove obsolete variables and their left over functionality#3009
Merged
timothy-nunn merged 17 commits intomainfrom Dec 20, 2023
Merged
Conversation
10 tasks
chris-ashe
changed the title
timothy-nunn
requested changes
Dec 6, 2023
| input parameter `impvar`, which may be set to a value between 3 and `nimp`, and the initial | ||
| estimate to use for the element's impurity fraction must be set using iteration | ||
| variable no. 102 (`fimpvar`). | ||
| isotopes and helium) may be used as an iteration variable. |
Collaborator
There was a problem hiding this comment.
Can we explain how this is done here, rather than just stating that it is possible?
Collaborator
Author
There was a problem hiding this comment.
Was going to sort this in #3001. Though can do a quick fix here
Collaborator
There was a problem hiding this comment.
I think that would be prefered given it doesn't really make sense right now.
Collaborator
Author
There was a problem hiding this comment.
@timothy-nunn Have added a description please check
timothy-nunn
approved these changes
Dec 20, 2023
timothy-nunn
approved these changes
Dec 20, 2023
timothy-nunn
deleted the
3007-remove-obsolete-variables-and-their-left-over-functionality
branch
chris-ashe
added a commit
that referenced
this pull request
Apr 22, 2024
…3009) * fgamp removed and placed in obsolete * divleg_profile_inner placed in obsolete * divleg_profile_outer placed in obsolete * iprmnloss placed in obsolete * rho_ecrh set as obsolete * ifispact set as obsolete * fms* placed as obsolete * quench_detection_ef marked as obsolete * farc4tf marked as obsolete * impvar marked as obsolete * fimpvar marked as obsolete * integration test removal of fimpvar and impvar * impurity docs update * Added fimpvar back in as obsolete * black fixes * Remove rho_ecrh from input --------- Co-authored-by: Timothy <75321887+timothy-nunn@users.noreply.github.com>
chris-ashe
added a commit
that referenced
this pull request
Apr 22, 2024
…3009) * fgamp removed and placed in obsolete * divleg_profile_inner placed in obsolete * divleg_profile_outer placed in obsolete * iprmnloss placed in obsolete * rho_ecrh set as obsolete * ifispact set as obsolete * fms* placed as obsolete * quench_detection_ef marked as obsolete * farc4tf marked as obsolete * impvar marked as obsolete * fimpvar marked as obsolete * integration test removal of fimpvar and impvar * impurity docs update * Added fimpvar back in as obsolete * black fixes * Remove rho_ecrh from input --------- Co-authored-by: Timothy <75321887+timothy-nunn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fimpvarseems to be obsolete though is not stated as suchimpvaris obsolete so should be documented as suchifispactand all associated variables should be removed, as it is not used.rho_ecrhseems to be obsolete so should be removed.All
fms*variables seem to be uselessreal(dp) :: fmsbc
!! Martensitic fraction of steel in (non-existent!) bucking cylinder
real(dp) :: fmsbl
!! Martensitic fraction of steel in blanket
real(dp) :: fmsdwe
!! Martensitic fraction of steel in cryostat
real(dp) :: fmsdwi
!! Martensitic fraction of steel in vacuum vessel
real(dp) :: fmsfw
!! Martensitic fraction of steel in first wall
real(dp) :: fmsoh
!! Martensitic fraction of steel in central solenoid
real(dp) :: fmssh
!! Martensitic fraction of steel in shield
real(dp) :: fmstf
!! Martensitic fraction of steel in TF coil
farc4tfseems to be obsolete and should be removedquench_detection_efseems to be obsolete. CHECK QUENCH MODELiprimnlossseems to be obsoletedivleg_profile_inneranddivleg_profile_outerseem to be obsoletefgampis seemingly obsoleteChecklist
I confirm that I have completed the following checks: