Plot dat opt dat removal#3021
Merged
timothy-nunn merged 5 commits intomainfrom Jan 11, 2024
Merged
Conversation
also remove comment referencing now-deleted plot_dat function also add points for 2d scan to example scan input file
timothy-nunn
requested changes
Jan 11, 2024
Collaborator
timothy-nunn
left a comment
timothy-nunn
left a comment
There was a problem hiding this comment.
@clmould all looks good to me, just one fix thats my fault and one QOL change
timothy-nunn
approved these changes
Jan 11, 2024
chris-ashe
pushed a commit
that referenced
this pull request
Apr 22, 2024
* stop opt.dat being created and remove references to it in docs * remove references to plot.dat in documentation * stop data being written to plot.dat and stop plot.dat being produced also remove comment referencing now-deleted plot_dat function also add points for 2d scan to example scan input file * tidy up example scan input file based on review comments
chris-ashe
pushed a commit
that referenced
this pull request
Apr 22, 2024
* stop opt.dat being created and remove references to it in docs * remove references to plot.dat in documentation * stop data being written to plot.dat and stop plot.dat being produced also remove comment referencing now-deleted plot_dat function also add points for 2d scan to example scan input file * tidy up example scan input file based on review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #3015
PLOT.DATandOPT.DATfiles were created during aPROCESSrun but were empty and unused so stopping these from being created and removing references to them in documentation.Checklist
I confirm that I have completed the following checks: