fix wrongly reporting multiple obsolete vars when only one is present in input file#3024
Merged
timothy-nunn merged 2 commits intomainfrom Feb 8, 2024
Conversation
… in input file
- add missing obsolete variables to obsolete_vars.py
- add ValueError to report obsolete variables to replace STOP 1
timothy-nunn
requested changes
Jan 24, 2024
Collaborator
timothy-nunn
left a comment
timothy-nunn
left a comment
There was a problem hiding this comment.
I like the idea of consolidating the help message and hints into obsolete_vars.py however I think the logic that generates the error messages could be improved to provide more flexibility when defining a obsolete variable that has no replacement but has a help message.
In fact, I'm not so sure stellarator_message would be printed out if you added one of the obsolete variables (from the Kallenbach model) to it.
timothy-nunn
approved these changes
Feb 8, 2024
timothy-nunn
deleted the
3020-bug-multiple-obsolete-variables-reported-when-only-one-is-present-in-input-file
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #3020
Checklist
I confirm that I have completed the following checks: