Skip to content

stop overwriting value of emult#3035

Merged
timothy-nunn merged 1 commit intomainfrom
1594-emult-is-overwritten-with-hard-coded-value-in-ccfe_hcpb-regardless-of-input-value
Jan 29, 2024
Merged

stop overwriting value of emult#3035
timothy-nunn merged 1 commit intomainfrom
1594-emult-is-overwritten-with-hard-coded-value-in-ccfe_hcpb-regardless-of-input-value

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented Jan 29, 2024

Description

Closes #1594
Stops value of emult being overwritten with hard-coded value in hcpb.py

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould requested a review from mkovari January 29, 2024 10:50
@clmould clmould marked this pull request as ready for review January 29, 2024 10:56
@mkovari
Copy link
Copy Markdown
Collaborator

mkovari commented Jan 29, 2024

Does this change the results of any of the tests?

@clmould
Copy link
Copy Markdown
Collaborator Author

clmould commented Jan 29, 2024

@mkovari I don't think any test results have changed - the tests all still pass on the CI and I also ran the tests locally to check the integration tests (which are currently not being tested in the CI) and none have failed

@mkovari
Copy link
Copy Markdown
Collaborator

mkovari commented Jan 29, 2024

The large tomakak regression test (regression-5-percent-py38) does run the CCFE hcpb model where the deleted code is (emult=1.269), but since the default is also 1.269 it makes no difference.

@clmould clmould requested a review from timothy-nunn January 29, 2024 13:33
@timothy-nunn timothy-nunn merged commit 846e953 into main Jan 29, 2024
@timothy-nunn timothy-nunn deleted the 1594-emult-is-overwritten-with-hard-coded-value-in-ccfe_hcpb-regardless-of-input-value branch January 29, 2024 13:34
@mkovari mkovari mentioned this pull request Feb 6, 2024
chris-ashe pushed a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

emult is overwritten with hard-coded value in ccfe_hcpb regardless of input value

3 participants