152 PF coil#3036
Merged
jonmaddock merged 6 commits intomainfrom Feb 6, 2024
Merged
Conversation
jonmaddock
requested changes
Feb 5, 2024
Contributor
jonmaddock
left a comment
jonmaddock
left a comment
There was a problem hiding this comment.
Content is fine, but there's a bit of back-and-forth and formatting fixes (perhaps check pre-commit is working with black alright?). Can you rebase and fixup these commits to condense them to reflect only the required changes?
jonmaddock
approved these changes
Feb 6, 2024
chris-ashe
pushed a commit
that referenced
this pull request
Apr 22, 2024
* ✨ add pf current safety factor * 🎨 black formatting * ✏️ update varialbe description * 🎨 remove change to fdene bound * 🐛 fix default SF value * ✅ update large tokamak to pass regression test --------- Co-authored-by: apearce <alexaner.pearce@ukaea.uk>
chris-ashe
pushed a commit
that referenced
this pull request
May 1, 2024
* ✨ add pf current safety factor * 🎨 black formatting * ✏️ update varialbe description * 🎨 remove change to fdene bound * 🐛 fix default SF value * ✅ update large tokamak to pass regression test --------- Co-authored-by: apearce <alexaner.pearce@ukaea.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #152