1541 calling of avail from stellaratorife does not take into account iavail#3037
Merged
chris-ashe merged 2 commits intomainfrom Jan 30, 2024
Conversation
j-a-foster
approved these changes
Jan 30, 2024
Collaborator
j-a-foster
left a comment
There was a problem hiding this comment.
The TODO has been correctly done and matches calling the same model elsewhere in the code.
chris-ashe
added a commit
that referenced
this pull request
Apr 22, 2024
…iavail (#3037) * fix avail for IFE * stellerator avail fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As per discussion in !601, IFE/Stellarator call the availability model. However, they both call the avail subroutine without taking into account the iavail flag. However, other calls to availability models take into account the iavail flag:
Upon further inspection it has been seen that
availis specifcally for IFE use so has not been changed.Though for the stellarator model any of the avaialbility models can be used as the same components are used between the model (tokamak) and the stellarator.
The stellarator module now runs
availability.run(output=True)to allow the user to specify theavailswitch for their preferred model.Checklist
I confirm that I have completed the following checks: