Constraint type bug in in dat.py#3040
Merged
jonmaddock merged 2 commits intoukaea:mainfrom Feb 5, 2024
Merged
Conversation
Maintain constraint order to preserve equality/inequality constraint types in generated IN.DATs
UQ runs often overstep filename size limit
ajpearcey
approved these changes
Feb 5, 2024
Collaborator
ajpearcey
left a comment
ajpearcey
left a comment
There was a problem hiding this comment.
Happy for this to be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a new
IN.DATfile from an existingMFILE.DAT, the constraints are being ordered numerically. This is unwanted if fixing f-values so that equality and inequality constraints are separated, rather than all being equalities, as they become mixed up.Preventing this re-ordering preserves what's eq and what's ineq when using the
neqnsvariable; the firstneqnsare eqs, rest are ineqs. This is now preserved fromMFILE.DATtoIN.DAT.