Collate cost models#3045
Conversation
|
@j-a-foster if you want to do anymore removals here feel free. I dunno how access works on forks but let me know if you have problems and i'll fix it |
|
As far as I can work out its not possible to inject the custom cost model while using either the Is there any preference about how this could be done/if it needs to be done?
For point 3 my last commit unifies the running interface between Let me know thoughts and I can modify as needed. |
202728f to
37a0525
Compare
37a0525 to
90b809d
Compare
|
Thanks for this James. @timothy-nunn can you review this please? Thanks. |
timothy-nunn
left a comment
There was a problem hiding this comment.
Confirmed this does not change the running of SingleRun or VaryRun or change any of the large-tokamak values.
|
@j-a-foster have you used this interface yet, and do you have any insights on how easy it is to use custom cost models? |
|
@timothy-nunn I've created an MR in the cost model repo that reflects the changes made here and checked that it works. Currently the only example is in the private cost model repo but we could create an example in this repo of how a user can set up their own custom cost model to work with PROCESS. |
Description
Collates cost models into one interface and does a bit of cleanup while I was there
Checklist
I confirm that I have completed the following checks: