Added check to see if fimp(2) deviates from default value, if it does…#3053
Merged
Added check to see if fimp(2) deviates from default value, if it does…#3053
Conversation
… write a warning message to use ralpne instead.
chris-ashe
pushed a commit
that referenced
this pull request
Apr 22, 2024
#3053) * Added check to see if fimp(2) deviates from default value, if it does write a warning message to use ralpne instead. * Added stop to enforce the message, mofidified message
chris-ashe
pushed a commit
that referenced
this pull request
May 1, 2024
#3053) * Added check to see if fimp(2) deviates from default value, if it does write a warning message to use ralpne instead. * Added stop to enforce the message, mofidified message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… write a warning message to use ralpne instead.
Description
This value is controlled by ralpne , in fact changing fimp(2) does not change the value of the parameter. It also doesn't make sense that a user would set these two parameters to different values in the first place.
However, as fimp(2) is part of the fimp array, it's not straight forward to remove it as an input variable. All members of fimp(1:13) are inputs, and all of them are output (and still used by other parts of the code). A generic fortran function loop for looping through arrays is used to set them as inputs. It doesn't seem elegant to add a specific exception to this function.
I have added a warning and stop to the user when they change fimp(2) from the default value, and they are told to use ralpne instead.
Checklist
I confirm that I have completed the following checks: