Issue #1871#3062
Merged
timothy-nunn merged 2 commits intomainfrom Feb 20, 2024
Merged
Conversation
timothy-nunn
approved these changes
Feb 20, 2024
timothy-nunn
deleted the
1871-division-by-zero-in-superconductor-calculation
branch
chris-ashe
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Issue #1871 * Update pfcoil.py syntax --------- Co-authored-by: Michael Kovari <michael.kovari@ukaea.uk> Co-authored-by: Timothy Nunn <timothy.nunn@ukaea.uk>
chris-ashe
pushed a commit
that referenced
this pull request
May 1, 2024
* Issue #1871 * Update pfcoil.py syntax --------- Co-authored-by: Michael Kovari <michael.kovari@ukaea.uk> Co-authored-by: Timothy Nunn <timothy.nunn@ukaea.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CS properties were calculated even when they are not required (
iohcl=0). On some occasions this led to division by zero sinceawpohwas initialised to zero. I have taken the calculations out of theisumatoption list to eliminate duplicated code, and added an if statement so CS calculations are only done wheniohcl /= 0.The structure of
pfcoil.pyis confusing and I can't guarantee this problem will never recurr.I confirm that I have completed the following checks: