Skip to content

Removal of obsolete model A for first wall - issue 389 #3085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonmaddock merged 1 commit into from
Mar 5, 2024
Merged

Removal of obsolete model A for first wall - issue 389 #3085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions process/fw.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,23 +144,7 @@ def fw_temp(

# Model B is given for comparison
# Model C is used
# Model A is not used.

# Model A: LeClaire formula for circular pipes (NOT USED) !
# !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

# This gives a very small temperature differential, as the wall thickness is
# the same all the way round, but the surface area is bigger than that of a flat wall.

# Calculate peak temperature - occurs at (r,theta) = (bfw,0)
# bfw = thickness/2.0d0

# po.cosine_term(afw, bfw, 0.0D0, bfw, qpp, hcoeff, tkfw, tmthet)

# deltat_solid = bfw/tkfw * (qpp/pi + qppp*bfw/2.0D0) * log(bfw/afw) &
# - qppp/4.0D0/tkfw*(bfw**2-afw**2)

# tpeakfw = fwoutlet + deltat_solid + deltat_coolant + tmthet # in K
# Model A LeClaire formula for circular pipes (removed GitHub #389).

# Model B: Simple 1-dimensional calculation !
# !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Expand Down
4 changes: 0 additions & 4 deletions source/fortran/pulse_variables.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ module pulse_variables
real(dp) :: bctmp
!! first wall bulk coolant temperature (C)

real(dp) :: bfw
!! outer radius of each first wall structural tube (m) (0.5 * average of fwith and fwoth)

real(dp) :: dtstor
!! maximum allowable temperature change in stainless steel thermal storage block (K) (`istore=3`)

Expand Down Expand Up @@ -52,7 +49,6 @@ subroutine init_pulse_variables
implicit none

bctmp = 320.0D0
bfw = 0.0D0
dtstor = 300.0D0
istore = 1
itcycl = 1
Expand Down