Replaced local calculated eps variable with fortran variable as input#3102
Merged
Replaced local calculated eps variable with fortran variable as input#3102
Conversation
Collaborator
Author
|
Unsure whether need to change physics.py line 751 as it's calculated on an index by index basis. It's also not clear from the docstring/comments whether this |
mkovari
approved these changes
Mar 14, 2024
chris-ashe
pushed a commit
that referenced
this pull request
Apr 22, 2024
chris-ashe
pushed a commit
that referenced
this pull request
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced inverse aspect ratio calculated locally in
_plascar_bpolwith inputepswhich is the fortran variablephysics_variables.epsin subsequest functions which use_plascar_bpol. These functions arebpolandplasc.Closes #454
Checklist
I confirm that I have completed the following checks: