Skip to content

Fix CS Fatigue typos #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timothy-nunn merged 3 commits into from
Mar 15, 2024
Merged

Fix CS Fatigue typos #3103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adf61fc
🐛 fix typos in SIF equations
Mar 14, 2024
32fb942
🚨 fix black
Mar 14, 2024
9302059
✅ update test_cs_fatigue
Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions process/cs_fatigue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def surface_stress_intensity_factor(hoop_stress, t, w, a, c, phi):
m1 = 1.13e0 - 0.09e0 * a_c
m2 = -0.54e0 + 0.89e0 / (0.2e0 + a_c)
m3 = 0.5e0 - 1.0e0 / (0.65e0 + a_c) + 14.0e0 * (1 - a_c) ** 24.0e0
g = 1.0e0 + (0.1e0 + 0.35e0 * a_c**2.0e0) * (1.0e0 - sin_phi) ** 2.0e0
g = 1.0e0 + (0.1e0 + 0.35e0 * a_t**2.0e0) * (1.0e0 - sin_phi) ** 2.0e0
Comment thread
grmtrkngtn marked this conversation as resolved.
f_phi = (a_c**2.0e0 * cos_phi_2 + sin_phi**2.0e0) ** 0.25e0
p = 0.2e0 + a_c + 0.6e0 * a_t
H1 = 1.0e0 - 0.34e0 * a_t - 0.11e0 * a * a / (c * t)
Expand Down Expand Up @@ -205,7 +205,8 @@ def surface_stress_intensity_factor(hoop_stress, t, w, a, c, phi):
H2 = (
1.0e0
+ (-2.11e0 + 0.77e0 * c_a) * a_t # G21 * a / t
+ (0.55e0 - 0.72e0 * c_a * 0.75e0 + 0.14e0 * c_a * 1.5e0) * a_t_2 # G22
+ (0.55e0 - 0.72e0 * c_a**0.75e0 + 0.14e0 * c_a * 1.5e0)
* a_t_2 # G22
)

# compute the unitless geometric correction
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_cs_fatigue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class NcycleParam(NamedTuple):
t_structural_vertical=0.0063104538380405924,
t_structural_radial=0.0063104538380405924,
t_crack_radial=0.0026699999999999996,
expected_n_cycle=985.2543993462306,
expected_n_cycle=1113.5875631615095,
expected_t_crack_radial=0.0026699999999999996,
),
),
Expand Down