Replace q with just q95#3108
Merged
timothy-nunn merged 8 commits intomainfrom Feb 18, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3108 +/- ##
=======================================
Coverage 31.54% 31.55%
=======================================
Files 82 82
Lines 19567 19565 -2
=======================================
Hits 6173 6173
+ Misses 13394 13392 -2 ☔ View full report in Codecov by Sentry. |
bf30780 to
3b709b6
Compare
234bd3f to
83bc75f
Compare
006b20a to
91a2c7e
Compare
timothy-nunn
requested changes
Feb 18, 2025
Collaborator
timothy-nunn
left a comment
There was a problem hiding this comment.
Two minor style points
timothy-nunn
requested changes
Feb 18, 2025
Collaborator
timothy-nunn
left a comment
There was a problem hiding this comment.
Need to fix https://github.com/ukaea/PROCESS/actions/runs/13387816299/job/37388520836?pr=3502#step:7:1967 otherwise good to go
528cc6f to
af97a73
Compare
ajpearcey
pushed a commit
that referenced
this pull request
Feb 26, 2025
* update q -> q95 * Rename 'q' to 'q95' in multiple data files for clarity and consistency * Fix typo in safety factor description for q95 in input.f90 * 🔥 Remove q and replace with just q95 * ✅ Update q in tests * lint * add to obsolete variables * Refactor iotabar assignment for clarity in stellarator scaling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An update to #321 after merge.
qis now be in the input file as justq95Using
q95makes it more explicit than just usingqfor the edge and the first assignment inphysics()was to setq95 = qChecklist
I confirm that I have completed the following checks: