Skip to content

Warning when profile parameters are reset in parabolic_paramterisation#3115

Merged
timothy-nunn merged 1 commit intomainfrom
510-internal-code-overwrite-of-input-parameters
May 1, 2024
Merged

Warning when profile parameters are reset in parabolic_paramterisation#3115
timothy-nunn merged 1 commit intomainfrom
510-internal-code-overwrite-of-input-parameters

Conversation

@timothy-nunn
Copy link
Copy Markdown
Collaborator

Outputs the following warning if the parabolic parameterisation is inappropriately used

process.plasma_profiles - WARNING - Parabolic plasma profiles is used for an L-Mode plasma, but the physics variables do not describe an L-Mode plasma. 'rhopedt', 'rhopedn', 'teped', 'tesep', 'neped', 'nesep', and 'tbeta' have all been reset to L-Mode appropriate values

Tested by using a modified large-tokamak input file with ipedestal=0, the warning is output.

@timothy-nunn timothy-nunn linked an issue Mar 26, 2024 that may be closed by this pull request
@timothy-nunn timothy-nunn requested a review from ajpearcey March 26, 2024 13:58
@mkovari
Copy link
Copy Markdown
Collaborator

mkovari commented Mar 27, 2024

It might be good to mention explicitly that ipedestal=0 in the error message.

You might also change parabolic_paramterisation to 'parabolic_parameterisation' if you are really keen.

@timothy-nunn timothy-nunn requested a review from jonmaddock April 24, 2024 09:48
Copy link
Copy Markdown
Collaborator

@ajpearcey ajpearcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@timothy-nunn timothy-nunn merged commit 3e0c328 into main May 1, 2024
@timothy-nunn timothy-nunn deleted the 510-internal-code-overwrite-of-input-parameters branch May 1, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Internal code overwrite of input parameters

3 participants