782 simple model to calculate the allowable current density in a superconducting coil#3116
Merged
timothy-nunn merged 3 commits intomainfrom Mar 27, 2024
Conversation
timothy-nunn
approved these changes
Mar 27, 2024
Collaborator
|
Michael, does this remove everything the original issue referred to? |
Collaborator
|
Yes, this seems to close out the original issue. It seems that the Subroutine |
timothy-nunn
deleted the
782-simple-model-to-calculate-the-allowable-current-density-in-a-superconducting-coil
branch
chris-ashe
pushed a commit
that referenced
this pull request
Apr 22, 2024
* removed unused commented out sections for tfc_model * remove mention of tfc_model in error message if using thkcas with istell=1 * set unused tfc_model error as obsolete
chris-ashe
pushed a commit
that referenced
this pull request
May 1, 2024
* removed unused commented out sections for tfc_model * remove mention of tfc_model in error message if using thkcas with istell=1 * set unused tfc_model error as obsolete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #782.
Removed previously commented out sections of code relating to the tfc_model which is no longer used (unused in over 4 years). Removed mention of tfc_model in error relating to stellarators, and marked error 104 as obsolete (error to do with tfc_model).