Skip to content

Fix Stellarator to allow it to run on open-source process#3121

Merged
timothy-nunn merged 4 commits intomainfrom
stellarator-2
Apr 25, 2024
Merged

Fix Stellarator to allow it to run on open-source process#3121
timothy-nunn merged 4 commits intomainfrom
stellarator-2

Conversation

@timothy-nunn
Copy link
Copy Markdown
Collaborator

Description

Allows Stellarator to run by updating it to use the new physics interface post-conversion.

Adds in the following calculation for VV stress to enable constraint 65:

sctfcoil_module.vv_stress_quench = (
    f_vv_actual
    * 1e6
    * ((build_variables.d_vv_in + build_variables.d_vv_out) / 2)
)

Modifies the SingleRun initialisation order slightly so that the correct cost model is passed to Stellarator/IFE

@grmtrkngtn
Copy link
Copy Markdown
Collaborator

grmtrkngtn commented Apr 4, 2024

I was looking into some of the errors that are output after a single run. I think the order the models are called needs to be looked at to see if it makes sense.

Additionally, we assume in the Stellarator model that the plasma current is 0. (Stellarators do have a lower plasma current than Tokamaks, but it may not necessarily be exactly 0).

However, this 0 plasma current is being used in some calculations which is throwing up divide by 0 errors. We should therefore consider how this is manifest in the code.

Perhaps it will be easier to resolve these once it's merged back in.

@timothy-nunn
Copy link
Copy Markdown
Collaborator Author

The plasma current being 0 only seems to throw errors on output, so do we need to consider what we call for output when running stellarator because if stuff is diving by 0 the output probably doesn't make sense for a stellarator ?

@timothy-nunn timothy-nunn self-assigned this Apr 4, 2024
@grmtrkngtn
Copy link
Copy Markdown
Collaborator

grmtrkngtn commented Apr 4, 2024

Yes, looking into it further this parameter nu_star (normalized collisionality) may be a property of interest but the calculation is just lifted directly from tokamak output and it doesn't work so we might as well *turn it off for stellarators.

@grmtrkngtn
Copy link
Copy Markdown
Collaborator

grmtrkngtn commented Apr 5, 2024

Further to this, a lot of the output errors are cleared up when you use Jorrit's input file. The Felix-Stuart one is missing a few things which lead to these errors.

@timothy-nunn timothy-nunn requested a review from grmtrkngtn April 24, 2024 15:30
@grmtrkngtn grmtrkngtn marked this pull request as ready for review April 25, 2024 08:39
Copy link
Copy Markdown
Collaborator

@grmtrkngtn grmtrkngtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

@timothy-nunn timothy-nunn merged commit c0f08bf into main Apr 25, 2024
@timothy-nunn timothy-nunn deleted the stellarator-2 branch April 25, 2024 09:24
chris-ashe pushed a commit that referenced this pull request May 1, 2024
* Fix Stellarator to allow it to run on open-source process

* import rether into stellarator

* Use new plasma profiles module instead of fortran version

* Remove import of profiles_module

---------

Co-authored-by: ym1906 <graeme.turkington@ukaea.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants