Conversation
mkovari
force-pushed
the
392-olivier-sauters-formulas-including-negative-triangularity
branch
from
f84b700 to
00132d7
Compare
added 2 commits
April 5, 2024 13:24
mkovari
changed the title
Collaborator
Author
|
See detailed comments in the issue #392. |
timothy-nunn
requested changes
Apr 17, 2024
Collaborator
timothy-nunn
left a comment
timothy-nunn
left a comment
There was a problem hiding this comment.
One minor change for code quality, one question to ensure this change is utilised to its fullest potential
|
|
||
| return xsect0 | ||
|
|
||
| def Sauter_geometry(self, a, r0, kap, tri): |
Collaborator
There was a problem hiding this comment.
Even though its a persons name, I think Sauter should be lower case
|
|
||
| # Cross-sectional area | ||
| physics_variables.xarea = self.xsecta(xi, thetai, xo, thetao) | ||
| # icurr = 8 specifies use of the Sauter geometry as well as plasma current. |
Collaborator
There was a problem hiding this comment.
Will it ever make sense to use Sauter geometry without using the Sauter plasma current?
Collaborator
Author
There was a problem hiding this comment.
Yes, I suppose so. That would involve a new switch. Maybe a new issue?
Collaborator
There was a problem hiding this comment.
Ok. If you make this into a new issue we can discuss it there
timothy-nunn
approved these changes
Apr 17, 2024
mkovari
deleted the
392-olivier-sauters-formulas-including-negative-triangularity
branch
chris-ashe
pushed a commit
that referenced
this pull request
Apr 22, 2024
…3128) * Minor refactor of culcur option icurr=8 * Replaced qpsi by q95 in unit tests for culcur. * Sauter's geometric formulae. Improved test for negative temperature in temperature margin calc. * Correct sauter_geometry method name --------- Co-authored-by: Michael Kovari <michael.kovari@ukaea.uk> Co-authored-by: Timothy Nunn <timothy.nunn@ukaea.uk>
chris-ashe
pushed a commit
that referenced
this pull request
May 1, 2024
…3128) * Minor refactor of culcur option icurr=8 * Replaced qpsi by q95 in unit tests for culcur. * Sauter's geometric formulae. Improved test for negative temperature in temperature margin calc. * Correct sauter_geometry method name --------- Co-authored-by: Michael Kovari <michael.kovari@ukaea.uk> Co-authored-by: Timothy Nunn <timothy.nunn@ukaea.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor refactor of
culcurinphysics.py, as described in #392:Update docstring.
Rename qpsi in culcur as q95.
Eliminate curhat since it's not necessary.
Test for a range of values of triangularity.