3096 cant write to new indat with pf coil position variables#3132
Merged
j-a-foster merged 2 commits intomainfrom Apr 26, 2024
Merged
Conversation
…AT from IN.DAT with indexed values
…sition-variables Keeping branch up-to-date with main for testing
chris-ashe
approved these changes
Apr 26, 2024
Collaborator
chris-ashe
left a comment
chris-ashe
left a comment
There was a problem hiding this comment.
Had a call and @j-a-foster explained the situation. The number of cpt values match that of the total number of coils so the fix is good to go.
| coheof = 1.85D7 | ||
| cpt = 0.0D0 | ||
| cptdin = 4.0D4 | ||
| cptdin = (/4.0D4, 4.0D4, 4.0D4, & |
Collaborator
There was a problem hiding this comment.
Do the number of cpt values in the default match that for the number of PF coils and their group assignment?
Collaborator
There was a problem hiding this comment.
Had a call and @j-a-foster explained the situation. The number of cpt values match that of the total number of coils
chris-ashe
pushed a commit
that referenced
this pull request
May 1, 2024
…AT from IN.DAT with indexed values (#3132)
je-cook
deleted the
3096-cant-write-to-new-indat-with-pf-coil-position-variables
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Made
rjconpfandcptdinexplicit arrays inpfcoil_variables.f90so input files with indexed values for these variables can be used for writing a new input file usingwrite_new_in_dat.py.Checklist
I confirm that I have completed the following checks: