Skip to content

Investigate and fix scan x failure#3146

Merged
timothy-nunn merged 6 commits intomainfrom
3071-investigate-scan-x-failure
May 1, 2024
Merged

Investigate and fix scan x failure#3146
timothy-nunn merged 6 commits intomainfrom
3071-investigate-scan-x-failure

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented Apr 18, 2024

Description

Closes #3071 and re-enables integration test test_scan which was previously being skipped due to this issue

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould linked an issue Apr 18, 2024 that may be closed by this pull request
@clmould clmould marked this pull request as ready for review May 1, 2024 13:30
@clmould clmould requested a review from timothy-nunn May 1, 2024 13:30
@clmould clmould force-pushed the 3071-investigate-scan-x-failure branch from f925681 to c85b0a8 Compare May 1, 2024 13:49
Copy link
Copy Markdown
Collaborator

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Clair, this was a really weird problem! Cheers

@timothy-nunn timothy-nunn merged commit f238ffe into main May 1, 2024
@timothy-nunn timothy-nunn deleted the 3071-investigate-scan-x-failure branch May 1, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate Scan x failure

2 participants