1110 remove scipyzeros from python utilities#3149
Merged
timothy-nunn merged 7 commits intomainfrom Apr 24, 2024
Merged
Conversation
timothy-nunn
approved these changes
Apr 24, 2024
chris-ashe
pushed a commit
that referenced
this pull request
May 1, 2024
* issue 1110 mod completed * added a mod * added correction * added corecctions for flake and black * made a mod * black and flake mods * Remove trailing comma in mfile to csv json --------- Co-authored-by: Timothy Nunn <timothy.nunn@ukaea.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Very simple papercut replace scipy.zeros in mfile_comparison.py with numpy.zeros. In conducting this alteration the CI test failed on the integration test within test_examples.py and this turned out to be an error (a missing comma) in mfile_to_csv_vars.json (Thanks to Tim for that one) within process/io. All fixed now and all tests passed.