3164 updated itpa confinement scalings itpa20#3166
Merged
timothy-nunn merged 3 commits intomainfrom May 1, 2024
Merged
Conversation
…b.com:ukaea/PROCESS into 3164-updated-itpa-confinement-scalings-itpa20
chris-ashe
reviewed
Apr 30, 2024
chris-ashe
approved these changes
May 1, 2024
Collaborator
chris-ashe
left a comment
chris-ashe
left a comment
There was a problem hiding this comment.
I am happy enough with the changes. Results are output correctly and the docs are updated
Collaborator
|
@j-a-foster Can you please check also |
j-a-foster
approved these changes
May 1, 2024
Collaborator
j-a-foster
left a comment
j-a-foster
left a comment
There was a problem hiding this comment.
I'm happy with the changes and the output is correct. Ready for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ITPA scaling
Checklist
I confirm that I have completed the following checks: