Skip to content

WIP:Update the heating and current drive docs to include all models#3171

Merged
chris-ashe merged 34 commits intomainfrom
update_heating_and_current_drive_docs1
May 30, 2024
Merged

WIP:Update the heating and current drive docs to include all models#3171
chris-ashe merged 34 commits intomainfrom
update_heating_and_current_drive_docs1

Conversation

@chris-ashe
Copy link
Copy Markdown
Collaborator

Description

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe added the Documentation Improvements or additions to documentation label May 1, 2024
@chris-ashe chris-ashe requested a review from j-a-foster May 1, 2024 15:29
@chris-ashe chris-ashe marked this pull request as draft May 1, 2024 15:30
Comment thread documentation/proc-pages/eng-models/heating_and_current_drive/NBI/iter_nb.md Outdated
Copy link
Copy Markdown
Collaborator

@j-a-foster j-a-foster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than comments, happy with NBI docs.

Comment thread documentation/proc-pages/eng-models/heating_and_current_drive/NBI/nbi_overview.md Outdated
Comment thread documentation/proc-pages/eng-models/heating_and_current_drive/NBI/nbi_overview.md Outdated
Comment thread documentation/proc-pages/eng-models/heating_and_current_drive/NBI/nbi_overview.md Outdated
Comment thread documentation/proc-pages/eng-models/heating_and_current_drive/NBI/iter_nb.md Outdated
Comment thread documentation/proc-pages/eng-models/heating_and_current_drive/NBI/iter_nb.md Outdated
Comment thread documentation/proc-pages/eng-models/heating_and_current_drive/NBI/culham_nb.md Outdated
Comment thread documentation/proc-pages/eng-models/heating_and_current_drive/NBI/culham_nb.md Outdated
Copy link
Copy Markdown
Collaborator

@j-a-foster j-a-foster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from comments, happy with rest of the HCD docs.

Comment thread documentation/proc-pages/eng-models/heating_and_current_drive/RF/cutoff_ecrh.md Outdated
@chris-ashe chris-ashe marked this pull request as ready for review May 30, 2024 08:57
@chris-ashe chris-ashe removed the request for review from timothy-nunn May 30, 2024 08:57
Copy link
Copy Markdown
Collaborator

@j-a-foster j-a-foster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with corrections. Ready for merge.

@chris-ashe chris-ashe merged commit ef2ed31 into main May 30, 2024
@chris-ashe chris-ashe deleted the update_heating_and_current_drive_docs1 branch May 30, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update heating and current drive documentation to demonstrate all models and variables.

3 participants