Skip to content

remove variables from pacpmw calculation which are already in fcsht calc#3236

Merged
mkovari merged 3 commits intomainfrom
1874-error-in-total-pulsed-power-system-load
Jul 2, 2024
Merged

remove variables from pacpmw calculation which are already in fcsht calc#3236
mkovari merged 3 commits intomainfrom
1874-error-in-total-pulsed-power-system-load

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented Jul 1, 2024

Description

Closes #1874

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould linked an issue Jul 1, 2024 that may be closed by this pull request
@clmould clmould requested a review from mkovari July 1, 2024 15:22
@mkovari
Copy link
Copy Markdown
Collaborator

mkovari commented Jul 1, 2024

The stellarator regression test has not converged. Any ideas?

Also the regression test results have been truncated due to their large size, so I can't see the summary at the end.

@timothy-nunn timothy-nunn requested a review from grmtrkngtn July 2, 2024 10:30
@mkovari
Copy link
Copy Markdown
Collaborator

mkovari commented Jul 2, 2024

Minor changes to two variables as expected. No change in the power balance - the changes only affect the power that is used to calculate the costs.

@mkovari mkovari merged commit df7a9a9 into main Jul 2, 2024
@mkovari mkovari deleted the 1874-error-in-total-pulsed-power-system-load branch July 2, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in Total pulsed power system load

3 participants