Calculation of Tresca stress in TF winding pack#3265
Merged
Conversation
ajpearcey
changed the title
mkovari
reviewed
Aug 5, 2024
| numpy.absolute(sig_tf_r), numpy.absolute(sig_tf_r - sig_tf_z) | ||
| ) | ||
| sig_tf_tresca = numpy.maximum( | ||
| sig_tf_tresca_tmp1, numpy.absolute(sig_tf_z - sig_tf_t) |
Collaborator
There was a problem hiding this comment.
I am not sure why you have included
So I think all you need is one line
sig_tf_tresca_tmp1 = numpy.maximum(
numpy.absolute(sig_tf_z - sig_tf_t), numpy.absolute(sig_tf_r - sig_tf_z)
)and probably some explanation in the issue.
mkovari
approved these changes
Aug 5, 2024
Collaborator
mkovari
left a comment
mkovari
left a comment
There was a problem hiding this comment.
Any changes to the output?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #580