3241 vgap and vgap2 are not well named#3319
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3319 +/- ##
==========================================
- Coverage 26.62% 26.03% -0.60%
==========================================
Files 76 76
Lines 17567 18036 +469
==========================================
+ Hits 4677 4695 +18
- Misses 12890 13341 +451 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ajpearcey
requested changes
Sep 23, 2024
Collaborator
ajpearcey
left a comment
ajpearcey
left a comment
There was a problem hiding this comment.
Overall looks good, but i think a few files slipped into the PR
File not needed
Collaborator
Author
|
@ajpearcey I removed those two files, let me know any other changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It wasn't clear to me what these variables referred to exactly, therefore I have renamed them to
vgap_xpoint_divertor (vertical gap between xpoint and divertor)
vgap_vv_thermalshield (vertical gap between vacuum vessel and thermal shield)