3245 fix stellarator regression test#3330
Merged
timothy-nunn merged 2 commits intomainfrom Sep 25, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3330 +/- ##
=======================================
Coverage 26.62% 26.62%
=======================================
Files 76 76
Lines 17569 17569
=======================================
Hits 4677 4677
Misses 12892 12892 ☔ View full report in Codecov by Sentry. |
timothy-nunn
force-pushed
the
3245-fix-stellarator-regression-test
branch
from
7df2262 to
bf041bc
Compare
grmtrkngtn
approved these changes
Sep 25, 2024
Collaborator
grmtrkngtn
left a comment
grmtrkngtn
left a comment
There was a problem hiding this comment.
These are minor numerical changes and should not drastically change the design. Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finds a new initial point for the Stellarator regression test. I had to relax some of the constraints and change the initial point using a vary run.
This initial point appears to be very sensitive so I suspect we will see this regression test failing in the future.
stellarator.MFILE.DAT.txt
stellarator.OUT.DAT.txt