Output radial build components to MFile#3348
Merged
timothy-nunn merged 1 commit intomainfrom Oct 11, 2024
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3348 +/- ##
==========================================
+ Coverage 26.65% 26.67% +0.02%
==========================================
Files 76 76
Lines 17610 17596 -14
==========================================
Hits 4694 4694
+ Misses 12916 12902 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fffce4c to
e6f53f0
Compare
Collaborator
|
How would you insert a new component? |
Collaborator
Author
@mkovari You can append items to the radial build array Lines 2208 to 2210 in 5eeaeff The radial build is the order so this append statement needs to be inserted at the correct point in the code, between the two append statements this new component would be between. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates how the radial build thicknesses are written to the MFile. The data is collected in an array before outputting all of the elements at the end.
The same array is used for the OUT.DAT radial build and MFILE.DAT variables. Therefore, some of the descriptions have changed in both files.
In the OUT.DAT, there is no addition anymore so the components listed as (
d_vv_in + shldith) are now given seperately on two lines.The MFile contains a flattened dictionary of the radial build components. Each radial build element provides three lines in the MFile, where
<n>is the index of the component (in order from the centreline, starting from 1):radial_label(<n>): the name of the radial build elementradial_cum(<n>): the radius of the outboard edge of the radial build elementradial_label(<n>))E.g.
I have attached the old and new ST and LT OUT.DATs
st_regression.NEW.OUT.DAT.txt
st_regression.OUT.DAT.txt
large_tokamak.NEW.OUT.DAT.txt
large_tokamak.OUT.DAT.txt
st_regression.NEW.MFILE.DAT.txt
large_tokamak.NEW.MFILE.DAT.txt
FYI @je-cook @athoynilimanew