Skip to content

Remove plasma profiles f902#3349

Merged
timothy-nunn merged 1 commit intomainfrom
remove-plasma-profiles-f902
Oct 21, 2024
Merged

Remove plasma profiles f902#3349
timothy-nunn merged 1 commit intomainfrom
remove-plasma-profiles-f902

Conversation

@timothy-nunn
Copy link
Copy Markdown
Collaborator

@timothy-nunn timothy-nunn commented Oct 11, 2024

Converts current_drive to use the plasma profile refactor, rather than the old profiles_module.

@timothy-nunn timothy-nunn force-pushed the remove-plasma-profiles-f902 branch from 3ed75df to a646f41 Compare October 21, 2024 09:17
@timothy-nunn timothy-nunn requested review from grmtrkngtn and removed request for grmtrkngtn October 21, 2024 09:17
Copy link
Copy Markdown
Collaborator

@grmtrkngtn grmtrkngtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@timothy-nunn timothy-nunn force-pushed the remove-plasma-profiles-f902 branch from a646f41 to 102db45 Compare October 21, 2024 13:40
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 21, 2024

Codecov Report

❌ Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.12%. Comparing base (b68ac63) to head (102db45).
⚠️ Report is 620 commits behind head on main.

Files with missing lines Patch % Lines
process/current_drive.py 33.33% 6 Missing ⚠️
process/main.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3349   +/-   ##
=======================================
  Coverage   27.11%   27.12%           
=======================================
  Files          76       76           
  Lines       17736    17738    +2     
=======================================
+ Hits         4810     4812    +2     
  Misses      12926    12926           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn merged commit 7953569 into main Oct 21, 2024
@timothy-nunn timothy-nunn deleted the remove-plasma-profiles-f902 branch October 21, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants