1105 lifetime variables definitions#3352
Merged
j-a-foster merged 6 commits intomainfrom Oct 21, 2024
Merged
Conversation
chris-ashe
reviewed
Oct 21, 2024
Merging main in to keep branch up to date.
chris-ashe
reviewed
Oct 21, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3352 +/- ##
==========================================
+ Coverage 27.11% 27.21% +0.09%
==========================================
Files 76 76
Lines 17736 17756 +20
==========================================
+ Hits 4810 4832 +22
+ Misses 12926 12924 -2 ☔ View full report in Codecov by Sentry. |
chris-ashe
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes avail_2 not modifying component lifetimes in line with the calculated availability and made sure costs.py uses calendar years not FPY.
Checklist
I confirm that I have completed the following checks: