Implement new suite of bootstrap current scalings#3355
Merged
timothy-nunn merged 28 commits intomainfrom Nov 13, 2024
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3355 +/- ##
==========================================
+ Coverage 27.11% 27.13% +0.01%
==========================================
Files 77 77
Lines 17816 17921 +105
==========================================
+ Hits 4831 4862 +31
- Misses 12985 13059 +74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add calculation of volume averaged pressure in plasma_profiles.md. This also add the core pressure and volume averaged pressure to the output. Assuming a parabolic profile - Implement bootstrap fraction calculation using Andrade et al formula in physics.py. This is currently implemented and exported with no tests and notes of applicability regimes
- Add calculation of volume averaged pressure in plasma_profiles.md. This also add the core pressure and volume averaged pressure to the output. Assuming a parabolic profile - Implement bootstrap fraction calculation using Andrade et al formula in physics.py. This is currently implemented and exported with no tests and notes of applicability regimes
54c4cb3 to
9e57e4c
Compare
kj5248
reviewed
Nov 7, 2024
Collaborator
kj5248
left a comment
There was a problem hiding this comment.
Had a look at the docs files and plot_proc, there are some changes throughout
…ap_current.md Co-authored-by: Jonathan Matthews <115085094+kj5248@users.noreply.github.com>
…ap_current.md Co-authored-by: Jonathan Matthews <115085094+kj5248@users.noreply.github.com>
…ap_current.md Co-authored-by: Jonathan Matthews <115085094+kj5248@users.noreply.github.com>
…ap_current.md Co-authored-by: Jonathan Matthews <115085094+kj5248@users.noreply.github.com>
…ap_current.md Co-authored-by: Jonathan Matthews <115085094+kj5248@users.noreply.github.com>
… bootstrap comparison
Collaborator
Author
|
@kj5248 Changes pushed, please check again |
Covered in CITATION.cff and README.md.
* allow process version to be printed to terminal * add version monkeypatch to test_run_mode
7757b49 to
9baa160
Compare
kj5248
reviewed
Nov 11, 2024
Collaborator
kj5248
left a comment
There was a problem hiding this comment.
Single thing, otherwise I believe it is all good
…ore to volume averaged value ratio
kj5248
approved these changes
Nov 11, 2024
timothy-nunn
approved these changes
Nov 13, 2024
Collaborator
timothy-nunn
left a comment
There was a problem hiding this comment.
Just one comment regarding profile assumptions. Feel free to merge if you dont think its a problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the documentation and codebase, primarily focusing on the addition of new bootstrap current scaling methods and improvements to plotting functions.
Documentation Updates:
Codebase Improvements:
pltmethods for better encapsulation.plot_bootstrap_comparisonto generate a comparison plot of bootstrap current fractions using various scaling methods.main_plotandmainfunctions to include the new bootstrap comparison plot.main_plotfunction comment.Plasma Profiles:
calculate_profile_factors.This pull request includes significant updates to the documentation and codebase, particularly focusing on the bootstrap current models and plotting functions. The most important changes include the addition of new bootstrap current scaling methods, updates to the plotting functions to use axis objects, and enhancements to the documentation.Documentation Updates:
ARIES,Andrade,Hoang,Wong,Gi) and their descriptions inbootstrap_current.md.Codebase Enhancements:
plot_proc.pyto useaxisobjects instead ofpltfor plotting functions.plot_bootstrap_comparisonto visualize bootstrap current fractions.main_plotandmainfunctions to include the new bootstrap comparison plot.Physics Calculations:
physicsfunction.outplasfunction.Minor Fixes:
plasma_current_MAtoplasma_current_mainplot_proc.py.scipyinphysics.pyto support new calculations.Checklist
I confirm that I have completed the following checks: