Convert stellarator_configuration to Python#3392
Merged
timothy-nunn merged 1 commit intomainfrom Dec 11, 2024
Merged
Conversation
timothy-nunn
commented
Nov 13, 2024
Comment on lines
+118
to
+119
| max_gyrotron_frequency = 1.0D9 | ||
| te0_ecrh_achievable = 1.0D2 |
Collaborator
Author
There was a problem hiding this comment.
@stuartmuldrew I added these so I could run yours and Felix's old file. Are you happy with these defaults?
Collaborator
Author
There was a problem hiding this comment.
Previously, these values defaulting to 0 resulted in Ignition point: Heating Power (MW) being written to MFile as NaN (I presume this was ok)... however now it causes an error in the code and stops the MFile being written
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3392 +/- ##
==========================================
+ Coverage 27.62% 27.64% +0.02%
==========================================
Files 77 78 +1
Lines 18044 18077 +33
==========================================
+ Hits 4984 4997 +13
- Misses 13060 13080 +20 ☔ View full report in Codecov by Sentry. |
jonmaddock
approved these changes
Dec 9, 2024
timothy-nunn
deleted the
3391-convert-stellarator_configurationf90-to-python
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert stellarator_configuration (except module variables) to Python