3350 tool to automatically convert obsolete variables from input file#3397
Merged
timothy-nunn merged 5 commits intomainfrom Dec 4, 2024
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3397 +/- ##
==========================================
+ Coverage 27.71% 28.43% +0.71%
==========================================
Files 77 77
Lines 18084 19215 +1131
==========================================
+ Hits 5012 5463 +451
- Misses 13072 13752 +680 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timothy-nunn
requested changes
Nov 20, 2024
Collaborator
timothy-nunn
left a comment
There was a problem hiding this comment.
I have found several bugs that its not unreasonable to expect will occur in real-world input files.
I need to additionally consider the merits of doing this in-situ while running PROCESS versus this being a script that produces another input file.
…ment. Modified parsing to find variables with spacing around equals. Added error for when there is a list of replacements
timothy-nunn
approved these changes
Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modified this validate_input function and added a CLI argument "replace_obsolete"
Now if you pass this argument when you run PROCESS it will automatically convert the variables, spit out the conversion in the terminal and write a comment in the input file where the name was changed.