Skip to content

3350 tool to automatically convert obsolete variables from input file#3397

Merged
timothy-nunn merged 5 commits intomainfrom
3350-tool-to-automatically-convert-obsolete-variables-from-input-file
Dec 4, 2024
Merged

3350 tool to automatically convert obsolete variables from input file#3397
timothy-nunn merged 5 commits intomainfrom
3350-tool-to-automatically-convert-obsolete-variables-from-input-file

Conversation

@grmtrkngtn
Copy link
Copy Markdown
Collaborator

I modified this validate_input function and added a CLI argument "replace_obsolete"

Now if you pass this argument when you run PROCESS it will automatically convert the variables, spit out the conversion in the terminal and write a comment in the input file where the name was changed.

@grmtrkngtn grmtrkngtn linked an issue Nov 14, 2024 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 14, 2024

Codecov Report

❌ Patch coverage is 9.52381% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.43%. Comparing base (d9801ca) to head (b979161).
⚠️ Report is 598 commits behind head on main.

Files with missing lines Patch % Lines
process/main.py 9.52% 38 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3397      +/-   ##
==========================================
+ Coverage   27.71%   28.43%   +0.71%     
==========================================
  Files          77       77              
  Lines       18084    19215    +1131     
==========================================
+ Hits         5012     5463     +451     
- Misses      13072    13752     +680     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have found several bugs that its not unreasonable to expect will occur in real-world input files.

I need to additionally consider the merits of doing this in-situ while running PROCESS versus this being a script that produces another input file.

Comment thread process/main.py Outdated
Comment thread process/main.py Outdated
Comment thread process/main.py
Comment thread process/main.py Outdated
…ment. Modified parsing to find variables with spacing around equals. Added error for when there is a list of replacements
@timothy-nunn timothy-nunn merged commit 2be48a8 into main Dec 4, 2024
@timothy-nunn timothy-nunn deleted the 3350-tool-to-automatically-convert-obsolete-variables-from-input-file branch December 4, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tool to automatically convert obsolete variables from input file

3 participants