Skip to content

3049 review and clarify timings#3413

Merged
timothy-nunn merged 6 commits intomainfrom
3049-review-and-clarify-timings
Dec 2, 2024
Merged

3049 review and clarify timings#3413
timothy-nunn merged 6 commits intomainfrom
3049-review-and-clarify-timings

Conversation

@j-a-foster
Copy link
Copy Markdown
Collaborator

@j-a-foster j-a-foster commented Nov 29, 2024

Description

Renames timing variables to clarify their meanings. The docs have been updated to reflect this as well as redrawing of the plot that details the current vs time over a pulse.

These are the variables that have been renamed:

  • tburn - t_burn
  • tbrnmn - t_burn_min
  • tohs - t_current_ramp_up
  • tdwell - t_between_pulse
  • tpulse - t_pulse_repetition
  • tqnch - t_ramp_down
  • tramp - t_precharge
  • ftburn - ft_burn
  • ftohs - ft_current_ramp_up
  • tcycle - t_cycle

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@j-a-foster j-a-foster linked an issue Nov 29, 2024 that may be closed by this pull request
9 tasks
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 43.13725% with 29 lines in your changes missing coverage. Please review.

Project coverage is 28.58%. Comparing base (73d1488) to head (66259a4).
Report is 205 commits behind head on main.

Files with missing lines Patch % Lines
process/physics.py 0.00% 12 Missing ⚠️
process/pfcoil.py 0.00% 5 Missing ⚠️
process/vacuum.py 37.50% 5 Missing ⚠️
process/power.py 63.63% 4 Missing ⚠️
process/evaluators.py 0.00% 1 Missing ⚠️
process/io/plot_proc.py 0.00% 1 Missing ⚠️
process/io/plot_scans.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3413      +/-   ##
==========================================
+ Coverage   28.27%   28.58%   +0.30%     
==========================================
  Files          77       77              
  Lines       18428    18865     +437     
==========================================
+ Hits         5210     5392     +182     
- Misses      13218    13473     +255     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chris-ashe
Copy link
Copy Markdown
Collaborator

Just to make it easier incase someone comes looking can you put the variable names before and after in the PR description box

@j-a-foster
Copy link
Copy Markdown
Collaborator Author

I've updated the description to say which variables have been renamed.

@timothy-nunn timothy-nunn merged commit 7463ac7 into main Dec 2, 2024
@timothy-nunn timothy-nunn deleted the 3049-review-and-clarify-timings branch December 2, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review and clarify timings

5 participants