3049 review and clarify timings#3413
Merged
timothy-nunn merged 6 commits intomainfrom Dec 2, 2024
Merged
Conversation
9 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3413 +/- ##
==========================================
+ Coverage 28.27% 28.58% +0.30%
==========================================
Files 77 77
Lines 18428 18865 +437
==========================================
+ Hits 5210 5392 +182
- Misses 13218 13473 +255 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Just to make it easier incase someone comes looking can you put the variable names before and after in the PR description box |
Collaborator
Author
|
I've updated the description to say which variables have been renamed. |
chris-ashe
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renames timing variables to clarify their meanings. The docs have been updated to reflect this as well as redrawing of the plot that details the current vs time over a pulse.
These are the variables that have been renamed:
tburn-t_burntbrnmn-t_burn_mintohs-t_current_ramp_uptdwell-t_between_pulsetpulse-t_pulse_repetitiontqnch-t_ramp_downtramp-t_prechargeftburn-ft_burnftohs-ft_current_ramp_uptcycle-t_cycleChecklist
I confirm that I have completed the following checks: