Skip to content

3258 add divertor and fwblanket lifetimes to st availability model#3414

Merged
j-a-foster merged 9 commits intomainfrom
3258-add-divertor-and-fwblanket-lifetimes-to-st-availability-model
Dec 6, 2024
Merged

3258 add divertor and fwblanket lifetimes to st availability model#3414
j-a-foster merged 9 commits intomainfrom
3258-add-divertor-and-fwblanket-lifetimes-to-st-availability-model

Conversation

@j-a-foster
Copy link
Copy Markdown
Collaborator

@j-a-foster j-a-foster commented Dec 4, 2024

Description

This adds the divertor and blanket lifetimes to the ST availability model. To streamline things, the divertor lifetime calculation was converted to its own function and inserted where the calculation was previously present in all availability models.

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@j-a-foster j-a-foster requested a review from chris-ashe December 4, 2024 15:23
@j-a-foster j-a-foster linked an issue Dec 4, 2024 that may be closed by this pull request
Comment thread process/availability.py Outdated
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 5, 2024

Codecov Report

❌ Patch coverage is 72.72727% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.57%. Comparing base (ec3c1f5) to head (9b41186).
⚠️ Report is 587 commits behind head on main.

Files with missing lines Patch % Lines
process/availability.py 72.72% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3414      +/-   ##
==========================================
+ Coverage   29.51%   29.57%   +0.05%     
==========================================
  Files          77       77              
  Lines       19049    19078      +29     
==========================================
+ Hits         5622     5642      +20     
- Misses      13427    13436       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@chris-ashe chris-ashe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j-a-foster j-a-foster merged commit 0da8640 into main Dec 6, 2024
@chris-ashe chris-ashe deleted the 3258-add-divertor-and-fwblanket-lifetimes-to-st-availability-model branch December 6, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add divertor and FW/Blanket lifetimes to ST availability model

3 participants