Skip to content

Detect string variable types in the Python-Fortran dicts#3421

Merged
timothy-nunn merged 1 commit intomainfrom
string-variable-types
Dec 12, 2024
Merged

Detect string variable types in the Python-Fortran dicts#3421
timothy-nunn merged 1 commit intomainfrom
string-variable-types

Conversation

@timothy-nunn
Copy link
Copy Markdown
Collaborator

Add variables of string type to the Python-Fortran dictionaries. This should avoid problems like

File "/home/oliver/development/PROCESS/process/io/in_dat.py", line 695, in parameter_type
    param_type = dicts["DICT_VAR_TYPE"][name]
                 ~~~~~~~~~~~~~~~~~~~~~~^^^^^^
KeyError: 'fwcoolant'

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.56%. Comparing base (7844aa2) to head (d1a3582).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3421   +/-   ##
=======================================
  Coverage   29.56%   29.56%           
=======================================
  Files          78       78           
  Lines       19131    19131           
=======================================
  Hits         5656     5656           
  Misses      13475    13475           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timothy-nunn timothy-nunn marked this pull request as ready for review December 11, 2024 16:38
@timothy-nunn timothy-nunn requested a review from clmould December 11, 2024 16:39
@timothy-nunn
Copy link
Copy Markdown
Collaborator Author

@clmould worth talking to @oliverfunk to check that this works

@timothy-nunn timothy-nunn self-assigned this Dec 12, 2024
@timothy-nunn timothy-nunn merged commit f325923 into main Dec 12, 2024
@timothy-nunn timothy-nunn deleted the string-variable-types branch December 12, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants