Skip to content

Tidy TF resistive #3465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timothy-nunn merged 29 commits into from
Feb 13, 2025
Merged

Tidy TF resistive #3465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
b8e8e1d
:arrows_counterclockwise: Rename tfbusl to len_tf_bus for clarity and…
chris-ashe Nov 29, 2024
7937f34
:heavy_plus_sign: Add len_tf_bus as a input variable
chris-ashe Nov 29, 2024
e692ea6
:arrows_counterclockwise: Rename tfbusl to rho_tf_bus for clarity and…
chris-ashe Nov 29, 2024
38fc706
:arrows_counterclockwise: Refactor tfbusmas to m_tf_bus for clarity a…
chris-ashe Nov 29, 2024
5d8eba9
:arrows_counterclockwise: Rename n_tf to n_tf_coils for clarity and c…
chris-ashe Nov 29, 2024
3b0818a
:arrows_counterclockwise: Rename jbus to j_tf_bus for clarity and con…
chris-ashe Nov 29, 2024
a16f232
🔄 Refactor tflegres to res_tf_leg for clarity and consistency across …
chris-ashe Dec 2, 2024
c1f5f33
:arrows_counterclockwise: Rename presleg to p_tf_leg_resistive for cl…
chris-ashe Dec 2, 2024
fbbc5dd
:bug: Fix TF resistive power calc that used the total TF current inst…
chris-ashe Dec 2, 2024
fe65947
🔄 Rename ztot to res_tf_system_total
chris-ashe Dec 3, 2024
d897db6
:arrows_counterclockwise: Rename prescp to p_cp_resistive for clarity…
chris-ashe Dec 3, 2024
6b923d2
:bug: Remove 0.92 fudge value to frholeg
chris-ashe Jan 13, 2025
773a76b
:bug: Remove 0.92 fudge value from frhocp
chris-ashe Jan 13, 2025
23f5c4f
🔄 Rename 'ritfc' to 'c_tf_total' for consistency across the codebase
chris-ashe Jan 13, 2025
f5eee9a
🔄 Update comment for rho_tf_bus to specify GLIDCOP AL-15 as the defau…
chris-ashe Jan 13, 2025
f79e7e7
:bug: Refactor TF leg resistive power calculations to account for all…
chris-ashe Jan 13, 2025
6324d4e
🔄 Rename 'tfleng' to 'len_tf_coil' for consistency across the codebase
chris-ashe Jan 13, 2025
13c943e
🔄 Rename 'rhotfleg' to 'rho_tf_leg' for consistency across the codebase
chris-ashe Jan 13, 2025
75780e9
🔄 Rename 'fcoolleg' to 'f_a_tf_cool_outboard' for consistency across …
chris-ashe Jan 13, 2025
6fc0082
🔄 Rename 'tcpav' to 'temp_cp_average' for consistency across the code…
chris-ashe Jan 13, 2025
90cc78a
🔄 Rename 'tlegav' to 'temp_tf_legs_outboard' for consistency across t…
chris-ashe Jan 13, 2025
e2f9cc8
🔄 Rename 'rhocp' to 'rho_cp' for consistency across the codebase
chris-ashe Jan 13, 2025
b5bf734
🔄 Rename 'arealeg' to 'a_tf_leg_outboard' for consistency across the …
chris-ashe Jan 13, 2025
e1c3d51
🔄 Update resistive heating calculations and improve method documentat…
chris-ashe Jan 15, 2025
c0ecf64
:art: Pre commit check
chris-ashe Jan 31, 2025
7132b6b
🔄 Improve documentation for resistivity parameters and add comments f…
chris-ashe Feb 4, 2025
f3d2288
Removed undefined variable
j-a-foster Feb 6, 2025
e39ec3a
lint fix
chris-ashe Feb 12, 2025
8ce78d9
🔄 Add new obsolete variable mappings for TF parameters
chris-ashe Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion documentation/proc-pages/development/numba.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ from process.fortran import sctfcoil_variables as sctfv

@njit
def my_other_function(n):
return n + sctfv.n_tf
return n + sctfv.n_tf_coils
```

because Numba does not know what `sctfv` is.
Expand Down
4 changes: 2 additions & 2 deletions documentation/proc-pages/eng-models/tf-coil.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Two major types of toroidal field (TF) coils can be considered in PROCESS: Resis
This section presents the <em>PROCESS</em> TF coil models and how to use them. The associated module computes first the coil current from the plasma major radius and toroidal magnetic field. The inboard leg mid-plane cross-section geometry is then set up to the conductor level. The vertical geometry is defined and the TF components masses are deduced. The inboard mid-plane stress distributions, the coil inductance and the toroidal field ripple are then estimated. Finally, the resistive heating (if resistive coil) and the ratio between the critical current density and the conductor current density (superconducting coil) is estimated.

## TF coil currents
The total current flowing in the TF coil set \( I_\mathrm{TF}^\mathrm{tot} \) (`ritfc`) is calculated using the approximation of axisymmetry from the vacuum toroidal field at the plasma geometric centre \( B_\mathrm{T} \) (`bt`) and the plasma geometric major radius $ R_0 $ (`rmajor`):
The total current flowing in the TF coil set \( I_\mathrm{TF}^\mathrm{tot} \) (`c_tf_total`) is calculated using the approximation of axisymmetry from the vacuum toroidal field at the plasma geometric centre \( B_\mathrm{T} \) (`bt`) and the plasma geometric major radius $ R_0 $ (`rmajor`):
</p>

$$
Expand Down Expand Up @@ -1245,7 +1245,7 @@ Another subroutine, `tfspcall` is called outside `stfcoil` to estimate to check

| Parameter | description | Default |
| - | - | - |
| `n_tf` | Number of TF coils | 16 |
| `n_tf_coils` | Number of TF coils | 16 |
| `i_tf_sup` | Swich selecting the conductor technology: <br> - 0 : Water cooled copper (GLIDCOP) <br> - 1 : Superconducting TF magnets <br> - 2 : Helium cooled Aluminium magnets | 1 |
| `i_tf_sc_mat` | Swich for superconducting material <br> 1 : Nb$_3$Sn superconductor, ITER critical surface parameterization[^1], standard critical values <br> 2 : Bi-2212 high temperature superconductor <br> 3 : NbTi superconductor <br> 4 : Nb$_3$Sn superconductor, ITER critical surface parameterization[^1], user-defined critical parameters <br> 5 : WST Nb$_3$Sn parameterization <br> 6 : REBCO HTS tape in CroCo strand <br> 7 : Durham Ginzburg-Landau critical surface model for Nb-Ti <br> 8 : Durham Ginzburg-Landau critical surface model for REBCO <br> 9 : Hazelton experimental data combined with Zhai conceptual model for REBCO | 1 |

Expand Down
18 changes: 9 additions & 9 deletions examples/data/csv_output_large_tokamak_MFILE.DAT
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,14 +669,14 @@
Superconductor_material_________________________________________________ (i_tf_sc_mat)_________________ 1
Presence_of_TF_demountable_joints_______________________________________ (itart)_______________________ 0
TF_inboard_leg_support_strategy_________________________________________ (i_tf_bucking)________________ 1
Number_of_TF_coils______________________________________________________ (n_tf)________________________ 16
Number_of_TF_coils______________________________________________________ (n_tf_coils)________________________ 16
Inboard_leg_centre_radius_(m)___________________________________________ (r_tf_inboard_mid)____________ 3.1929E+00 OP
Outboard_leg_centre_radius_(m)__________________________________________ (r_tf_outboard_mid)___________ 1.4985E+01 OP
Total_inboard_leg_radial_thickness_(m)__________________________________ (dr_tf_inboard)_______________________ 8.6482E-01 ITV
Total_outboard_leg_radial_thickness_(m)_________________________________ (dr_tf_outboard)______________________ 8.6482E-01
Outboard_leg_toroidal_thickness_(m)_____________________________________ (tftort)______________________ 1.4145E+00 OP
Maximum_inboard_edge_height_(m)_________________________________________ (hmax)________________________ 8.8182E+00 OP
Mean_coil_circumference_(including_inboard_leg_length)_(m)______________ (tfleng)______________________ 4.7815E+01 OP
Mean_coil_circumference_(including_inboard_leg_length)_(m)______________ (len_tf_coil)______________________ 4.7815E+01 OP
Vertical_TF_shape_______________________________________________________ (i_tf_shape)__________________ 1
TF_coil_arc_point_0_R_(m)_______________________________________________ (xarc(1))_____________________ 3.6253E+00
TF_coil_arc_point_0_Z_(m)_______________________________________________ (yarc(1))_____________________ 4.5506E+00
Expand All @@ -689,9 +689,9 @@
TF_coil_arc_point_4_R_(m)_______________________________________________ (xarc(5))_____________________ 3.6253E+00
TF_coil_arc_point_4_Z_(m)_______________________________________________ (yarc(5))_____________________ -5.2909E+00
TF_cross-section_(total)_(m2)___________________________________________ (tfareain)____________________ 1.7350E+01
Total_steel_cross-section_(m2)__________________________________________ (a_tf_steel*n_tf)_____________ 1.2056E+01
Total_steel_cross-section_(m2)__________________________________________ (a_tf_steel*n_tf_coils)_____________ 1.2056E+01
Total_steel_TF_fraction_________________________________________________ (f_tf_steel)__________________ 6.9487E-01
Total_Insulation_cross-section_(total)_(m2)_____________________________ (a_tf_ins*n_tf)_______________ 8.6240E-01
Total_Insulation_cross-section_(total)_(m2)_____________________________ (a_tf_ins*n_tf_coils)_______________ 8.6240E-01
Total_Insulation_fraction_______________________________________________ (f_tf_ins)____________________ 4.9707E-02
Casing_cross_section_area_(per_leg)_(m2)________________________________ (acasetf)_____________________ 5.0816E-01
Inboard_leg_case_plasma_side_wall_thickness_(m)_________________________ (casthi)______________________ 6.0000E-02
Expand All @@ -705,7 +705,7 @@
Winding_pack_toroidal_width_2_(m)_______________________________________ (wwp2)________________________ 1.0896E+00 OP
Ground_wall_insulation_thickness_(m)____________________________________ (tinstf)______________________ 8.0000E-03
Winding_pack_insertion_gap_(m)__________________________________________ (tfinsgap)____________________ 1.0000E-02
Steel_WP_cross-section_(total)_(m2)_____________________________________ (aswp*n_tf)___________________ 3.9252E+00
Steel_WP_cross-section_(total)_(m2)_____________________________________ (aswp*n_tf_coils)___________________ 3.9252E+00
Steel_WP_fraction_______________________________________________________ (aswp/awpc)___________________ 4.2577E-01
Insulation_WP_fraction__________________________________________________ (aiwp/awpc)___________________ 4.9412E-02
Cable_WP_fraction_______________________________________________________ ((awpc-aswp-aiwp)/awpc)_______ 5.2482E-01
Expand All @@ -732,11 +732,11 @@
Steel_conduit_mass_per_coil_(kg)________________________________________ (whtconsh)____________________ 9.1497E+04 OP
Conduit_insulation_mass_per_coil_(kg)___________________________________ (whtconin)____________________ 2.4504E+03 OP
Total_conduit_mass_per_coil_(kg)________________________________________ (whtcon)______________________ 1.5475E+05 OP
Mass_of_each_TF_coil_(kg)_______________________________________________ (whttf/n_tf)__________________ 6.5696E+05 OP
Mass_of_each_TF_coil_(kg)_______________________________________________ (whttf/n_tf_coils)__________________ 6.5696E+05 OP
Total_TF_coil_mass_(kg)_________________________________________________ (whttf)_______________________ 1.0511E+07 OP
Nominal_peak_field_assuming_toroidal_symmetry_(T)_______________________ (bmaxtf)______________________ 1.1646E+01 OP
Total_current_in_all_TF_coils_(MA)______________________________________ (ritfc/1.D6)__________________ 2.0251E+02 OP
TF_coil_current_(summed_over_all_coils)_(A)_____________________________ (ritfc)_______________________ 2.0251E+08
Total_current_in_all_TF_coils_(MA)______________________________________ (c_tf_total/1.D6)__________________ 2.0251E+02 OP
TF_coil_current_(summed_over_all_coils)_(A)_____________________________ (c_tf_total)_______________________ 2.0251E+08
Actual_peak_field_at_discrete_conductor_(T)_____________________________ (bmaxtfrp)____________________ 1.2085E+01 OP
Winding_pack_current_density_(A/m2)_____________________________________ (jwptf)_______________________ 2.4422E+07 OP
Inboard_leg_mid-plane_conductor_current_density_(A/m2)__________________ (oacdcp)______________________ 1.1672E+07
Expand Down Expand Up @@ -1785,7 +1785,7 @@ casths = 0.05
ripmax = 0.6

* Number of TF coils
n_tf = 16
n_tf_coils = 16

* Groundwall insulation thickness [m]
tinstf = 0.008
Expand Down
18 changes: 9 additions & 9 deletions examples/data/large_tokamak_1_MFILE.DAT
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,14 +666,14 @@
Superconductor_material_________________________________________________ (i_tf_sc_mat)_________________ 1
Presence_of_TF_demountable_joints_______________________________________ (itart)_______________________ 0
TF_inboard_leg_support_strategy_________________________________________ (i_tf_bucking)________________ 1
Number_of_TF_coils______________________________________________________ (n_tf)________________________ 16
Number_of_TF_coils______________________________________________________ (n_tf_coils)________________________ 16
Inboard_leg_centre_radius_(m)___________________________________________ (r_tf_inboard_mid)____________ 3.1673E+00 OP
Outboard_leg_centre_radius_(m)__________________________________________ (r_tf_outboard_mid)___________ 1.4985E+01 OP
Total_inboard_leg_radial_thickness_(m)__________________________________ (dr_tf_inboard)_______________________ 9.1597E-01 ITV
Total_outboard_leg_radial_thickness_(m)_________________________________ (dr_tf_outboard)______________________ 9.1597E-01
Outboard_leg_toroidal_thickness_(m)_____________________________________ (tftort)______________________ 1.4145E+00 OP
Maximum_inboard_edge_height_(m)_________________________________________ (hmax)________________________ 8.8182E+00 OP
Mean_coil_circumference_(including_inboard_leg_length)_(m)______________ (tfleng)______________________ 4.7937E+01 OP
Mean_coil_circumference_(including_inboard_leg_length)_(m)______________ (len_tf_coil)______________________ 4.7937E+01 OP
Vertical_TF_shape_______________________________________________________ (i_tf_shape)__________________ 1
TF_coil_arc_point_0_R_(m)_______________________________________________ (xarc(1))_____________________ 3.6253E+00
TF_coil_arc_point_0_Z_(m)_______________________________________________ (yarc(1))_____________________ 4.5506E+00
Expand All @@ -686,9 +686,9 @@
TF_coil_arc_point_4_R_(m)_______________________________________________ (xarc(5))_____________________ 3.6253E+00
TF_coil_arc_point_4_Z_(m)_______________________________________________ (yarc(5))_____________________ -5.2909E+00
TF_cross-section_(total)_(m2)___________________________________________ (tfareain)____________________ 1.8229E+01
Total_steel_cross-section_(m2)__________________________________________ (a_tf_steel*n_tf)_____________ 1.2853E+01
Total_steel_cross-section_(m2)__________________________________________ (a_tf_steel*n_tf_coils)_____________ 1.2853E+01
Total_steel_TF_fraction_________________________________________________ (f_tf_steel)__________________ 7.0508E-01
Total_Insulation_cross-section_(total)_(m2)_____________________________ (a_tf_ins*n_tf)_______________ 8.4752E-01
Total_Insulation_cross-section_(total)_(m2)_____________________________ (a_tf_ins*n_tf_coils)_______________ 8.4752E-01
Total_Insulation_fraction_______________________________________________ (f_tf_ins)____________________ 4.6493E-02
Casing_cross_section_area_(per_leg)_(m2)________________________________ (acasetf)_____________________ 5.6444E-01
Inboard_leg_case_plasma_side_wall_thickness_(m)_________________________ (casthi)______________________ 6.0000E-02
Expand All @@ -702,7 +702,7 @@
Winding_pack_toroidal_width_2_(m)_______________________________________ (wwp2)________________________ 1.0901E+00 OP
Ground_wall_insulation_thickness_(m)____________________________________ (tinstf)______________________ 8.0000E-03
Winding_pack_insertion_gap_(m)__________________________________________ (tfinsgap)____________________ 1.0000E-02
Steel_WP_cross-section_(total)_(m2)_____________________________________ (aswp*n_tf)___________________ 3.8217E+00
Steel_WP_cross-section_(total)_(m2)_____________________________________ (aswp*n_tf_coils)___________________ 3.8217E+00
Steel_WP_fraction_______________________________________________________ (aswp/awpc)___________________ 4.1550E-01
Insulation_WP_fraction__________________________________________________ (aiwp/awpc)___________________ 4.7934E-02
Cable_WP_fraction_______________________________________________________ ((awpc-aswp-aiwp)/awpc)_______ 5.3656E-01
Expand All @@ -729,11 +729,11 @@
Steel_conduit_mass_per_coil_(kg)________________________________________ (whtconsh)____________________ 8.9310E+04 OP
Conduit_insulation_mass_per_coil_(kg)___________________________________ (whtconin)____________________ 2.3777E+03 OP
Total_conduit_mass_per_coil_(kg)________________________________________ (whtcon)______________________ 1.5446E+05 OP
Mass_of_each_TF_coil_(kg)_______________________________________________ (whttf/n_tf)__________________ 7.1402E+05 OP
Mass_of_each_TF_coil_(kg)_______________________________________________ (whttf/n_tf_coils)__________________ 7.1402E+05 OP
Total_TF_coil_mass_(kg)_________________________________________________ (whttf)_______________________ 1.1424E+07 OP
Nominal_peak_field_assuming_toroidal_symmetry_(T)_______________________ (bmaxtf)______________________ 1.2178E+01 OP
Total_current_in_all_TF_coils_(MA)______________________________________ (ritfc/1.D6)__________________ 2.1176E+02 OP
TF_coil_current_(summed_over_all_coils)_(A)_____________________________ (ritfc)_______________________ 2.1176E+08
Total_current_in_all_TF_coils_(MA)______________________________________ (c_tf_total/1.D6)__________________ 2.1176E+02 OP
TF_coil_current_(summed_over_all_coils)_(A)_____________________________ (c_tf_total)_______________________ 2.1176E+08
Actual_peak_field_at_discrete_conductor_(T)_____________________________ (bmaxtfrp)____________________ 1.2636E+01 OP
Winding_pack_current_density_(A/m2)_____________________________________ (jwptf)_______________________ 2.5602E+07 OP
Inboard_leg_mid-plane_conductor_current_density_(A/m2)__________________ (oacdcp)______________________ 1.1617E+07
Expand Down Expand Up @@ -1779,7 +1779,7 @@ casths = 0.05
ripmax = 0.6

* Number of TF coils
n_tf = 16
n_tf_coils = 16

* Groundwall insulation thickness [m]
tinstf = 0.008
Expand Down
Loading