🐛 Add output parameter to cryostat_output function#3522
Merged
timothy-nunn merged 1 commit intomainfrom Feb 3, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3522 +/- ##
==========================================
- Coverage 30.84% 30.84% -0.01%
==========================================
Files 80 80
Lines 19325 19326 +1
==========================================
Hits 5961 5961
- Misses 13364 13365 +1 ☔ View full report in Codecov by Sentry. |
timothy-nunn
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
process/build.pyfile to enhance the flexibility of thecryostat_outputmethod by allowing it to conditionally output geometry details based on a boolean parameter.Enhancements to conditional output:
process/build.py: Modified thecryostat_outputmethod to accept a boolean parameteroutput, which controls whether the cryostat geometry details are output to the file.process/build.py: Updated thecalculate_vertical_buildmethod to pass theoutputparameter to thecryostat_outputmethod, ensuring consistent behavior based on theoutputflag.Checklist
I confirm that I have completed the following checks: