Skip to content

🐛 Add output parameter to cryostat_output function#3522

Merged
timothy-nunn merged 1 commit intomainfrom
prevent_duplicate_cryostat_output
Feb 3, 2025
Merged

🐛 Add output parameter to cryostat_output function#3522
timothy-nunn merged 1 commit intomainfrom
prevent_duplicate_cryostat_output

Conversation

@chris-ashe
Copy link
Copy Markdown
Collaborator

@chris-ashe chris-ashe commented Jan 31, 2025

This pull request includes changes to the process/build.py file to enhance the flexibility of the cryostat_output method by allowing it to conditionally output geometry details based on a boolean parameter.

Enhancements to conditional output:

  • process/build.py: Modified the cryostat_output method to accept a boolean parameter output, which controls whether the cryostat geometry details are output to the file.
  • process/build.py: Updated the calculate_vertical_build method to pass the output parameter to the cryostat_output method, ensuring consistent behavior based on the output flag.

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 30.84%. Comparing base (71a1e29) to head (61eae9a).

Files with missing lines Patch % Lines
process/build.py 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3522      +/-   ##
==========================================
- Coverage   30.84%   30.84%   -0.01%     
==========================================
  Files          80       80              
  Lines       19325    19326       +1     
==========================================
  Hits         5961     5961              
- Misses      13364    13365       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timothy-nunn timothy-nunn merged commit 8d9aac2 into main Feb 3, 2025
@timothy-nunn timothy-nunn deleted the prevent_duplicate_cryostat_output branch February 3, 2025 13:44
@je-cook je-cook added the Bug Something isnt working label Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isnt working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants