Skip to content

Convert scan.f90 to Python#3526

Merged
timothy-nunn merged 3 commits intomainfrom
3430-convert-scanf90-to-python
Feb 19, 2025
Merged

Convert scan.f90 to Python#3526
timothy-nunn merged 3 commits intomainfrom
3430-convert-scanf90-to-python

Conversation

@timothy-nunn
Copy link
Copy Markdown
Collaborator

@timothy-nunn timothy-nunn commented Feb 5, 2025

Convert scan.f90 to Python

With the code in Python, the dict creation routine can now use the Python data structures to generate the IXC2NSWEEP, NSWEEP2IXC, and NSWEEP2VARNAME dicts without parsing fortran source code.

@timothy-nunn timothy-nunn linked an issue Feb 5, 2025 that may be closed by this pull request
@timothy-nunn timothy-nunn force-pushed the 3430-convert-scanf90-to-python branch from 8d4a893 to bda4d83 Compare February 5, 2025 11:12
@timothy-nunn timothy-nunn self-assigned this Feb 5, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 5, 2025

Codecov Report

❌ Patch coverage is 5.57103% with 339 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.19%. Comparing base (f700a31) to head (98f6bb6).
⚠️ Report is 480 commits behind head on main.

Files with missing lines Patch % Lines
process/scan.py 5.57% 339 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3526      +/-   ##
==========================================
- Coverage   31.64%   31.19%   -0.45%     
==========================================
  Files          83       83              
  Lines       19598    19937     +339     
==========================================
+ Hits         6202     6220      +18     
- Misses      13396    13717     +321     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn marked this pull request as draft February 5, 2025 17:08
@timothy-nunn timothy-nunn force-pushed the 3430-convert-scanf90-to-python branch 2 times, most recently from 242ef15 to 7417e84 Compare February 6, 2025 11:21
@timothy-nunn timothy-nunn marked this pull request as ready for review February 6, 2025 11:34
@timothy-nunn timothy-nunn force-pushed the 3430-convert-scanf90-to-python branch 5 times, most recently from d579ad3 to 2421165 Compare February 18, 2025 10:24
@timothy-nunn timothy-nunn force-pushed the 3430-convert-scanf90-to-python branch from 2421165 to 98f6bb6 Compare February 19, 2025 15:11
@timothy-nunn timothy-nunn merged commit 5b4e073 into main Feb 19, 2025
@timothy-nunn timothy-nunn deleted the 3430-convert-scanf90-to-python branch February 19, 2025 15:43
chris-ashe pushed a commit that referenced this pull request Feb 21, 2025
* Convert scan.f90 to Python

* Remove utilities.f90

* Move scan data into dictionary
chris-ashe pushed a commit that referenced this pull request Feb 21, 2025
* Convert scan.f90 to Python

* Remove utilities.f90

* Move scan data into dictionary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert scan.f90 to Python

3 participants