Skip to content

🐛 Add cryostat internal radius output and update obsolete variables#3527

Merged
timothy-nunn merged 1 commit intomainfrom
cryostat_obsolete_variables
Feb 6, 2025
Merged

🐛 Add cryostat internal radius output and update obsolete variables#3527
timothy-nunn merged 1 commit intomainfrom
cryostat_obsolete_variables

Conversation

@chris-ashe
Copy link
Copy Markdown
Collaborator

Description

  • Added a new po.ovarrf call to output the cryostat internal radius with the label "Cryostat internal radius (m)" and the variable fwbs_variables.r_cryostat_inboard. This allows plot_proc.py to plot the cryostat again.

  • : Added new obsolete variable mappings for cryostat dimensions, including clhsf, ddwex, clh1, and rpf2dewar. This should have been included in ❄️ Update cryostat docs #3501.

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

Copy link
Copy Markdown
Collaborator

@stuartmuldrew stuartmuldrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 30.84%. Comparing base (29fccbf) to head (5edffc5).

Files with missing lines Patch % Lines
process/build.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3527      +/-   ##
==========================================
- Coverage   30.84%   30.84%   -0.01%     
==========================================
  Files          80       80              
  Lines       19326    19327       +1     
==========================================
  Hits         5961     5961              
- Misses      13365    13366       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timothy-nunn timothy-nunn merged commit d246250 into main Feb 6, 2025
@timothy-nunn timothy-nunn deleted the cryostat_obsolete_variables branch February 6, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants