Update pfcoil_variables.f90 variables for clarity

[chris-ashe]

This PR changes the vast majority of the variables found in pfcoil_variables.f90 in attempt to make them more verbose, descriptive and easier to understand. This is due to many of the PF variables still being in the old Fortran style.

These changes are not exhaustive and the new variable name may not represent the variable exactly as its new name is inferred from its previous. Therefore some variables may change again in the future if their naming is found to not be accurate.

Namespace changes

Variables

Numbers

• ncirt -> n_pf_cs_plasma_circuits
• turns -> n_pf_coil_turns
• nohc -> n_cs_pf_coils
• ncls -> n_pf_coils_in_group
• ngrpmx -> n_pf_groups_max
• ngrp -> n_pf_coil_groups
• nclsmx -> n_pf_coils_in_group_max
• ngc -> n_pf_coils_max

---

Geometry

For the six vertical and radial variables there was a lot of name mangling when doing find and replace as the variables aren't verbose enough to what exactly they are for

• ra -> r_pf_coil_inner
• rb -> r_pf_coil_outer
• rpf -> r_pf_coil_middle
• rohc -> r_cs_middle
• ipfloc -> i_pf_location
• zh -> z_pf_coil_upper
• zl -> z_pf_coil_lower
• zpf -> z_pf_coil_middle
• pfrmax -> r_pf_coil_outer_max
• a_oh_turn -> a_cs_turn
• areaoh -> a_cs_poloidal
• vf -> f_a_pf_coil_void
• vfohc -> f_a_cs_void

---

Structures

• wtc -> m_pf_coil_conductor
• whtpf -> m_pf_coil_conductor_total
• wts -> m_pf_coil_structure
• whtpfs -> m_pf_coil_structure_total
• oh_steel_frac -> f_a_cs_steel
• pfmmax -> m_pf_coil_max

---

Currents

• cohbop -> j_cs_pulse_start
• rjpfalw -> j_pf_wp_critical
• coheof -> j_cs_flat_top_end
• ric -> c_pf_cs_coils_peak_ma
• curpfb -> c_pf_cs_coil_pulse_start_ma
• curpff -> c_pf_cs_coil_flat_top_ma
• curpfs -> c_pf_cs_coil_pulse_end_ma
• rjpfalw -> j_pf_wp_critical
• cpt -> c_pf_coil_turn
• cptdin -> c_pf_coil_turn_peak_input
• rjconpf -> j_pf_coil_wp_peak
• rjohc -> j_cs_critical_flat_top_end
• rjohc0 -> j_cs_critical_pulse_start
• jscoh_bop -> j_cs_conductor_critical_pulse_start
• jsocoh_eof -> j_cs_conductor_critical_flat_top_end
• fcohbof -> f_j_cs_start_end_flat_top
• fcohbop -> f_j_cs_start_pulse_end_flat_top
• fvssu -> fvs_cs_pf_total_ramp

---

Magnetic fields

• bmaxcs_lim -> b_cs_limit_max
• fbmaxcs -> fb_cs_limit_max
• bpf -> b_pf_coil_peak
• bmaxoh0 -> b_cs_peak_pulse_start
• bmaxoh -> b_cs_peak_flat_top_end

---

Volt-seconds / Fluxes

• vsohsu -> vs_cs_ramp
• vsohbn -> vs_cs_burn
• vsefsu -> vs_pf_coils_total_ramp
• vssu -> vs_cs_pf_total_ramp
• vsefbn -> vs_pf_coils_total_burn
• vsbn -> vs_cs_pf_total_burn
• vseft -> vs_pf_coils_total_pulse
• vsoh -> vs_cs_total_pulse
• vstot -> vs_cs_pf_total_pulse

---

• tmargoh -> temp_cs_margin
• pfclres -> rho_pf_coil
• isumatoh -> i_cs_superconductor
• isumatpf -> i_pf_superconductor
• ohhghf -> f_z_cs_tf_internal
• sxlg -> ind_pf_cs_plasma_mutual
• ipfres -> i_pf_superconductor
• powohres -> p_cs_resisitive_flat_top
• powpfres -> p_pf_coil_resisitve_total_flat_top

Checklist

I confirm that I have completed the following checks:

• My changes follow the PROCESS style guide
• I have justified any large differences in the regression tests caused by this pull request in the comments.
• I have added new tests where appropriate for the changes I have made.
• If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
• If I have made documentation changes, I have checked they render correctly.
• I have added documentation for my change, if appropriate.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 64.58333% with 17 lines in your changes missing coverage. Please review.

Project coverage is 31.21%. Comparing base (a33e522) to head (b9d8166).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
process/sctfcoil.py	0.00%	7 Missing ⚠️
process/io/plot_proc.py	0.00%	4 Missing ⚠️
process/init.py	62.50%	3 Missing ⚠️
process/costs.py	90.90%	1 Missing ⚠️
process/power.py	88.88%	1 Missing ⚠️
process/structure.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3538   +/-   ##
=======================================
  Coverage   31.21%   31.21%           
=======================================
  Files          83       83           
  Lines       19935    19935           
=======================================
  Hits         6223     6223           
  Misses      13712    13712           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[timothy-nunn]

Integration tests failing and one regression input file still contains obsolete variables.

Also a random file has been added, I have commented a '?'

[timothy-nunn]

Can't this just be None too?

[timothy-nunn]

?