Update synchrotron radiation docs and other variables

[chris-ashe]

Description

Follow on from some work partially done in #3386
Still waiting on conversion of impurity_radiation.f90 so updated the synchrotron radiation sections.

• The function psync_albajar_fidone() has been re-factored to actually take inputs as it was calling global physics variables.
• A new plotting script called psync_albajar_fidone_reflectivity.py has been added to documentation/proc-pages/scripts/plotting_scripts.

Namespace changes

Functions

---

Variables

• pcoreradpv -> pden_plasma_core_rad_mw
• pedgeradpv -> pden_plasma_outer_rad_mw
• maxradwallload -> pflux_fw_rad_max
• coreradius -> radius_plasma_core_norm
• palpfwmw -> p_fw_alpha_mw
• wallmw -> pflux_fw_neutron_mw

---

✨ New additions

• p_plasma_sync_mw: Represents the total synchrotron power from the plasma.

---

🐛 Bugs

There was never a variable representing the total synchrotron power from the plasma, instead it was always outputted as (pden_plasma_sync_mw*vol). This would cause parsing issues due to *. A new variable p_plasma_sync_mw has been created in physics_variables.f90 to fix this.

Checklist

I confirm that I have completed the following checks:

• My changes follow the PROCESS style guide
• I have justified any large differences in the regression tests caused by this pull request in the comments.
• I have added new tests where appropriate for the changes I have made.
• If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
• If I have made documentation changes, I have checked they render correctly.
• I have added documentation for my change, if appropriate.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 19.23077% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.20%. Comparing base (159ac62) to head (281ad4b).
⚠️ Report is 244 commits behind head on main.

Files with missing lines	Patch %	Lines
process/physics.py	0.00%	12 Missing ⚠️
process/physics_functions.py	26.66%	11 Missing ⚠️
process/stellarator.py	0.00%	9 Missing ⚠️
process/io/sankey_funcs.py	0.00%	4 Missing ⚠️
process/ife.py	0.00%	3 Missing ⚠️
process/io/plot_proc.py	0.00%	1 Missing ⚠️
process/objectives.py	0.00%	1 Missing ⚠️
process/power.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3541      +/-   ##
==========================================
- Coverage   31.20%   31.20%   -0.01%     
==========================================
  Files          83       83              
  Lines       19940    19943       +3     
==========================================
  Hits         6223     6223              
- Misses      13717    13720       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[j-a-foster]

Minor typos but otherwise the docs look good.

I'll review the variable changes once obsolete_vars.py has been updated.

[j-a-foster]

"syncrotorn" -> synchrotron

Don't need "given then by", "given by" is fine.

[j-a-foster]

Happy with the name changes listed in the overview.

[timothy-nunn]

Only change required is obsolete variables