Updated tprofile to teprofile and nprofile to neprofile.#3543
Merged
grmtrkngtn merged 4 commits intomainfrom Feb 17, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3543 +/- ##
=======================================
Coverage 31.31% 31.31%
=======================================
Files 81 81
Lines 19515 19515
=======================================
Hits 6111 6111
Misses 13404 13404 ☔ View full report in Codecov by Sentry. |
chris-ashe
requested changes
Feb 17, 2025
Collaborator
chris-ashe
left a comment
chris-ashe
left a comment
There was a problem hiding this comment.
Looks good, just a few small points to look over for clarity
chris-ashe
deleted the
3463-tprofile-and-nprofile-should-really-be-renamed-teprofile-and-neprofile
branch
ajpearcey
pushed a commit
that referenced
this pull request
Feb 26, 2025
* Updated tprofile to teprofile and nprofile to neprofile. * "Updated docs with teprofile and neprofile change" * update profile names * added explicit reference to electron
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renamed TProfile to TeProfile, to highlight that it is an electron profile. Slight update to docstring.
Likewise for NProfile.