3548 implement variable dt ratio#3549
Merged
grmtrkngtn merged 10 commits intomainfrom Feb 20, 2025
Merged
Conversation
…ration variable usage for f_tritium
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3549 +/- ##
==========================================
- Coverage 31.55% 31.18% -0.37%
==========================================
Files 82 83 +1
Lines 19565 20024 +459
==========================================
+ Hits 6173 6245 +72
- Misses 13392 13779 +387 ☔ View full report in Codecov by Sentry. |
chris-ashe
requested changes
Feb 20, 2025
chris-ashe
approved these changes
Feb 20, 2025
Collaborator
chris-ashe
left a comment
chris-ashe
left a comment
There was a problem hiding this comment.
Happy for this to be merged
chris-ashe
added a commit
that referenced
this pull request
Feb 21, 2025
* Added f_tritium as iteration variable * Added new constraint to check D/T ratio is equal to 1, subject to f_tritium being ixc * updated fuel composition to note availability of ixc and cc for f_tritium * Removed excess blank space * 📝 Enhance documentation on fuel ions mixture self-consistency and iteration variable usage for f_tritium * ✅ Add missing False values in NamedTuple initializations for consistency * removed blank spaces for better md formatting * Set boundl of f_tritium to 0 * Fixed typo in deuterium * Renamed constraint label for D/T mix --------- Co-authored-by: mn3981 <christopher.ashe@ukaea.uk>
chris-ashe
added a commit
that referenced
this pull request
Feb 21, 2025
* Added f_tritium as iteration variable * Added new constraint to check D/T ratio is equal to 1, subject to f_tritium being ixc * updated fuel composition to note availability of ixc and cc for f_tritium * Removed excess blank space * 📝 Enhance documentation on fuel ions mixture self-consistency and iteration variable usage for f_tritium * ✅ Add missing False values in NamedTuple initializations for consistency * removed blank spaces for better md formatting * Set boundl of f_tritium to 0 * Fixed typo in deuterium * Renamed constraint label for D/T mix --------- Co-authored-by: mn3981 <christopher.ashe@ukaea.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added f_tritium as an iteration variable and a constraint to ensure the fuel mixture fractions add up to 1
Checklist
I confirm that I have completed the following checks: