Removed tresca from some variable names, swapped for s_shear#3568
Merged
timothy-nunn merged 13 commits intomainfrom Mar 10, 2025
Merged
Removed tresca from some variable names, swapped for s_shear#3568timothy-nunn merged 13 commits intomainfrom
timothy-nunn merged 13 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3568 +/- ##
=======================================
Coverage 31.21% 31.21%
=======================================
Files 83 83
Lines 19938 19938
=======================================
Hits 6223 6223
Misses 13715 13715 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit 5e0e1f6.
ca07aa9 to
24aba4e
Compare
chris-ashe
approved these changes
Mar 7, 2025
Collaborator
chris-ashe
left a comment
There was a problem hiding this comment.
Happy with name changes
Collaborator
Author
|
@timothy-nunn Could you give final review and merge please. |
timothy-nunn
requested changes
Mar 7, 2025
Collaborator
timothy-nunn
left a comment
There was a problem hiding this comment.
Happy that these changes are added to obsolete vars and with the regression failures. However, the pre-commit job is failing, please fix it.
timothy-nunn
approved these changes
Mar 10, 2025
Collaborator
Author
|
Thanks Tim! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have changed the following variable names related to shear stress