Skip to content

Warn about fcohbop > 1 rather than preventing it#3573

Merged
jonmaddock merged 1 commit intomainfrom
99-central-solenoid-current-constraints
Mar 14, 2025
Merged

Warn about fcohbop > 1 rather than preventing it#3573
jonmaddock merged 1 commit intomainfrom
99-central-solenoid-current-constraints

Conversation

@jonmaddock
Copy link
Copy Markdown
Contributor

@jonmaddock jonmaddock commented Mar 7, 2025

When running the large tokamak regression test, I get this warning on the first run of the models, but not in any subsequent iterations.

@jonmaddock jonmaddock linked an issue Mar 7, 2025 that may be closed by this pull request
@jonmaddock jonmaddock requested a review from mkovari March 7, 2025 14:18
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 31.20%. Comparing base (e12bee9) to head (ab5ff59).

Files with missing lines Patch % Lines
process/pfcoil.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3573   +/-   ##
=======================================
  Coverage   31.20%   31.20%           
=======================================
  Files          83       83           
  Lines       19943    19943           
=======================================
  Hits         6223     6223           
  Misses      13720    13720           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonmaddock jonmaddock force-pushed the 99-central-solenoid-current-constraints branch from 031e83e to ab5ff59 Compare March 14, 2025 10:49
@jonmaddock jonmaddock requested a review from mkovari March 14, 2025 10:50
@jonmaddock jonmaddock self-assigned this Mar 14, 2025
@jonmaddock jonmaddock merged commit ecf30f1 into main Mar 14, 2025
@jonmaddock jonmaddock deleted the 99-central-solenoid-current-constraints branch March 14, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Central Solenoid current constraints

3 participants