Skip to content

🏋️ Calculate plasma fuelling masses#3598

Merged
timothy-nunn merged 3 commits intomainfrom
calculate_plasma_fuelling_masses
Mar 26, 2025
Merged

🏋️ Calculate plasma fuelling masses#3598
timothy-nunn merged 3 commits intomainfrom
calculate_plasma_fuelling_masses

Conversation

@chris-ashe
Copy link
Copy Markdown
Collaborator

This pull request includes significant updates to the process/physics.py and source/fortran/physics_variables.f90 files, focusing on the calculation and output of plasma mass variables. The most important changes include the addition of a new method for calculating plasma masses and the inclusion of these calculations in the output.

Changes in process/physics.py:

  • Added a new method calculate_plasma_masses to compute various plasma mass variables, including fuel ions, total ions, alpha particles, electrons, and the total plasma mass.
  • Updated the physics method to call calculate_plasma_masses and assign the results to corresponding variables in physics_variables.
  • Enhanced the outplas method to include the new plasma mass variables in the output file.

Changes in source/fortran/physics_variables.f90:

  • Introduced new variables to store the mass of plasma components in grams: m_plasma_fuel_ions_grams, m_plasma_ions_total_grams, m_plasma_alpha_grams, m_plasma_electron_grams, and m_plasma_grams.
  • Initialized the new plasma mass variables in the init_physics_variables subroutine.

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe added the Physics Relating to the physics models label Mar 20, 2025
@chris-ashe chris-ashe self-assigned this Mar 20, 2025
@chris-ashe chris-ashe changed the title Calculate plasma fuelling masses 🏋️ Calculate plasma fuelling masses Mar 20, 2025
@chris-ashe chris-ashe requested a review from timothy-nunn March 20, 2025 15:29
@chris-ashe chris-ashe force-pushed the calculate_plasma_fuelling_masses branch from 232128d to 75f0d3c Compare March 20, 2025 15:35
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 31.73%. Comparing base (cf82f05) to head (087d51a).
Report is 138 commits behind head on main.

Files with missing lines Patch % Lines
process/physics.py 57.14% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3598      +/-   ##
==========================================
+ Coverage   31.71%   31.73%   +0.01%     
==========================================
  Files          84       84              
  Lines       20152    20166      +14     
==========================================
+ Hits         6392     6400       +8     
- Misses      13760    13766       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chris-ashe chris-ashe force-pushed the calculate_plasma_fuelling_masses branch from 75f0d3c to 087d51a Compare March 21, 2025 16:13
@timothy-nunn timothy-nunn merged commit 03a8c56 into main Mar 26, 2025
14 of 18 checks passed
@timothy-nunn timothy-nunn deleted the calculate_plasma_fuelling_masses branch March 26, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Variables Physics Relating to the physics models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants