🔥 3572 remove tbr calculation#3605
Merged
timothy-nunn merged 5 commits intomainfrom Mar 27, 2025
Merged
Conversation
Closed
4ba2a3b to
02e6ec7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3605 +/- ##
==========================================
- Coverage 31.74% 31.67% -0.08%
==========================================
Files 85 86 +1
Lines 20161 22242 +2081
==========================================
+ Hits 6400 7045 +645
- Misses 13761 15197 +1436 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timothy-nunn
requested changes
Mar 27, 2025
Collaborator
timothy-nunn
left a comment
There was a problem hiding this comment.
Just need to put iblanket_thickness into obsolete variables
timothy-nunn
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on removing the Tritium Breeding Ratio (TBR) calculation for the CCFE HCPB model and simplifying related code. The most important changes include the removal of the TBR calculation function, adjustments to related input variables, and updates to documentation and test files.
Removal of TBR calculation:
process/hcpb.py: Removed thetbr_shimwellfunction, which calculates the Tritium Breeding Ratio.Code adjustments:
process/caller.py: Removed the code block that runs the TBR calculation for the CCFE HCPB model.process/init.py: Removed input checks and assignments related toiblanket_thicknessfor the TBR calculation.Documentation updates:
documentation/proc-pages/eng-models/fw-blanket.md: Updated the documentation to remove references to the TBR calculation for the CCFE HCPB model.Test file updates:
tests/integration/ref_dicts.json: Removed references toiblanket_thicknessand the TBR calculation from the test configuration.Checklist
I confirm that I have completed the following checks: