Rename TF coil variables, part 1#3608
Merged
timothy-nunn merged 21 commits intomainfrom Apr 10, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3608 +/- ##
=======================================
Coverage 36.13% 36.13%
=======================================
Files 88 88
Lines 22106 22106
=======================================
Hits 7988 7988
Misses 14118 14118 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
98e13e9 to
3e8b66f
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 60 out of 68 changed files in this pull request and generated 1 comment.
Files not reviewed (8)
- examples/data/csv_output_large_tokamak_MFILE.DAT: Language not supported
- examples/data/large_tokamak_1_MFILE.DAT: Language not supported
- examples/data/large_tokamak_2_MFILE.DAT: Language not supported
- examples/data/large_tokamak_3_MFILE.DAT: Language not supported
- examples/data/large_tokamak_4_MFILE.DAT: Language not supported
- examples/data/large_tokamak_IN.DAT: Language not supported
- examples/data/scan_MFILE.DAT: Language not supported
- examples/data/scan_example_file_IN.DAT: Language not supported
timothy-nunn
requested changes
Apr 9, 2025
Collaborator
timothy-nunn
left a comment
There was a problem hiding this comment.
Just one minor issue with obsolete variables. Will also need to be rebased to main
1aa3852 to
890b105
Compare
…e references across the codebase
…ency; update references across the codebase
…ate references across the codebase
…cy; update references across the codebase
…pdate references across the codebase
…erences across the codebase
…ency; update references across the codebase
… references across the codebase
… update references across the codebase
…ces across the codebase
…date references across the codebase
…erences across the codebase
…ncy; update references across the codebase
…eferences across the codebase
…e references across the codebase
…e references across the codebase
…tency; update references across the codebase
Co-authored-by: Timothy <75321887+timothy-nunn@users.noreply.github.com>
890b105 to
17868a0
Compare
67372ff to
b940ea7
Compare
timothy-nunn
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Namespace changes
Variables
whttf->m_tf_coils_totalaiwp->a_tf_coil_wp_turn_insulationbmaxtf->b_tf_inboard_peaktheta_coil->rad_tf_coil_toroidaltfareain->a_tf_coil_inboardh_cp_top->z_cp_toptftort->dx_tf_inboard_out_toroidaltfc_current->c_tf_coiljwptf->j_tf_wprbmax->r_b_tf_inboard_peaktfind->ind_tf_coilwhtconsh->m_tf_turn_steeltmpcry->temp_tf_cryothkcas->dr_tf_nose_casecasths->dx_tf_side_caseestotft->e_tf_magnetic_stored_totalFunctions
coilshap()->tf_coil_shape_inner()Checklist
I confirm that I have completed the following checks: